This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix tabs layout on iOS when using Shell navigation - #14773 #14877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Commenter does not have sufficient privileges for PR 14877 in repo xamarin/Xamarin.Forms |
|
@jfversluis Could you please run the pipeline for this PR? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This fixes issue xamarin#14773, for both iOS 14 and 15
TrinTragula
force-pushed
the
fix-14773-ios
branch
from
ef4ebc1
to
bbc96b4
Compare
|
@jfversluis Could you please run the pipeline again for this PR? I had to push some new changes (I deleted the previous commit from history in order to avoid some clutter) |
2 tasks
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Added a fix for another issue mentioned here |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
reviewed
Nov 16, 2021
jfversluis
approved these changes
Nov 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This fixes issue #14773, for both iOS 14 and 15. A PR for this already existed but didn't account for iOS 14.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Fixes the layout of a TabbedPage when using Shell navigation.
Before/After Screenshots
Testing Procedure
Please use the repo gently provided by @federicobenedetti in #14773 and follow the steps there.
PR Checklist