Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix issue interacting with a SwipeView inside a ScrollView on a TabbedPage #14902

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix issue interacting with a SwipeView inside a ScrollView on a TabbedPage. With IsSwipePagingEnabled="false" was re-enabling page swiping. This PR introduce changes to fix the issue.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Core Gallery and navigate to the issue 14897. Interact with the SwipeView available in Page 2 and then, try to swipe to move between tabs. If the page not swipe, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@tranb3r
Copy link

tranb3r commented Nov 17, 2021

@jfversluis @jsuarezruiz
I've just tested the nuget, and I confirm that the fix works in my app. No visible side-effect.
Thanks a lot guys !!!

@jfversluis jfversluis merged commit 393c458 into 5.0.0 Nov 18, 2021
@jfversluis jfversluis deleted the fix-14897 branch November 18, 2021 11:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants