This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Fix setting text decorations and text at the same time and respect changes #14907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
changed the title
jsuarezruiz
approved these changes
Nov 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Instead of using the UILabel.Text property, we now only use the UILabel.AttributedText property. This makes sure that no formatting or markup is left behind. The label is drawn differently depending on which property you set. This change is the last reference to UILabel.Text.
We should test very well if this doesn't break anywhere!11!!
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Go to issue 11954 and follow the instructions. Label should successfully enable/disable strikethrough
PR Checklist