Fix iOS scrolling outside ScrollView bounds #14926
Conversation
| @@ -286,6 +286,10 @@ void OnScrollToRequested(object sender, ScrollToRequestedEventArgs e) | |||
| break; | |||
| } | |||
| } | |||
| if(newOffset.X + ScrollView.Width > ContentSize.Width) | |||
There was a problem hiding this comment.
Could you include a sample and an UITest (tapping a Button and checking a Label value for example)?.
There was a problem hiding this comment.
Hi @jsuarezruiz
i added a test. If its not enough, please modify the test.
Thank you
There was a problem hiding this comment.
Thanks!. Could you rebase 5.0.0 branch to fix the conflicts?
There was a problem hiding this comment.
@jsuarezruiz
Conflicts fixed.
|
|
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @jfversluis |
jfversluis
added this to Issues in Progress
in 5.0.0 SR9 (Planning) - Target Date Jan. 19th
via automation
|
Nothing besides me merging it! |
|
For me, this change introduces a new bug where calling ScrollView.ScrollToAsync has no effect on iOS anymore. Managed to restore functionality by integrating the ScrollViewRenderer's source into my project, minus the four lines added in this revision. |
Description of Change
Perform scrolling inside the bounds of the ScrollView.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
If scrolling to an element, which is at the end of the list and setting ScrollToPosition to Start or Center the app now bahaves same as android.
Before/After Screenshots
Before:
After:
Testing Procedure
PR Checklist