This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android AppCompat] Add defensive code to prevent NRE in GetNativeSize #14933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
changed the title
jsuarezruiz
approved these changes
Dec 1, 2021
| IVisualElementRenderer visualElementRenderer = Android.Platform.GetRenderer(view); | ||
|
|
||
| if (visualElementRenderer == null || visualElementRenderer.View.IsDisposed()) |
There was a problem hiding this comment.
Do we know when this happen?
There was a problem hiding this comment.
Not really, I see it in the stack traces of the mentioned issues and this code was implemented for the fast renderers but not here. So I guess it doesn't hurt :)
jfversluis
added this to Issues in Progress
in 5.0.0 SR8 (Planning) - Target Date Dec. 15th
via automation
jfversluis
moved this from Issues in Progress
to Done
in 5.0.0 SR8 (Planning) - Target Date Dec. 15th
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR applies the fix from #12114 to the AppCompat versions for Android as well, hopefully fixing some sporadic exceptions.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None, hopefully no exceptions anymore!
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist