Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

removed a broken direct link to net47 dev pack #15124

Merged

Conversation

bondarenkod
Copy link
Contributor

@bondarenkod bondarenkod commented Feb 5, 2022

Hello!
Running the \build.ps1 -Target provision on the recent branch, I've noticed that the script cannot pass through all the steps:

Installing: https://download.microsoft.com/download/A/1/D/A1D07600-6915-4CB8-A931-9A980EF47BB7/NDP47-DevPack-KB3186612-ENU.exe
An error occurred when executing task 'provision-netsdk-local'.
Error: One or more errors occurred. (One or more errors occurred. (Response status code does not indicate success: 404 (Not Found).))
        Response status code does not indicate success: 404 (Not Found).

That happened due to line 107 in the file build.cake:

string[] netFrameworkSdksLocalInstall = new string[]
{
    "https://go.microsoft.com/fwlink/?linkid=2099470", //NET461 SDK
    "https://go.microsoft.com/fwlink/?linkid=874338", //NET472 SDK
    106: "https://go.microsoft.com/fwlink/?linkid=2099465", //NET47
    107: "https://download.microsoft.com/download/A/1/D/A1D07600-6915-4CB8-A931-9A980EF47BB7/NDP47-DevPack-KB3186612-ENU.exe", //net47 targeting pack
    "https://go.microsoft.com/fwlink/?linkid=2088517", //NET48 SDK
};

I've tried to solve this issue and found that the link https://go.microsoft.com/fwlink/?linkid=2099465 is pointing to the same (at least now) file name: ndp47-devpack-kb3186612-enu.exe, so I simply removed line 107 as needless. The link can be found from the https://support.microsoft.com/en-us/topic/the-net-framework-4-7-developer-pack-and-language-packs-80ad488a-bed3-3468-c9bd-4563a6f54636

I double-checked execution of the fixed provision command on a freshly installed win11+vs2019, the result is OK:
vmware_05_02_2022__21_10_07__6bf6ffdf-2f86-45b2-abec-c0b6030284f0

Could you verify and accept my PR?

@jfversluis jfversluis added the t/housekeeping ♻︎ Internal only changes, won't be included in release notes label Feb 8, 2022
@jfversluis
Copy link
Member

Seems good, thanks catch, thanks!

@jfversluis jfversluis merged commit 6e8bfc9 into xamarin:5.0.0 Feb 8, 2022
@bondarenkod bondarenkod deleted the 5.0.0-outdated-target-provision branch February 17, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
t/housekeeping ♻︎ Internal only changes, won't be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants