This repository has been archived by the owner on May 1, 2024. It is now read-only.
removed a broken direct link to net47 dev pack #15124
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Running the
\build.ps1 -Target provision
on the recent branch, I've noticed that the script cannot pass through all the steps:That happened due to line 107 in the file
build.cake
:I've tried to solve this issue and found that the link
https://go.microsoft.com/fwlink/?linkid=2099465
is pointing to the same (at least now) file name:ndp47-devpack-kb3186612-enu.exe
, so I simply removed line 107 as needless. The link can be found from the https://support.microsoft.com/en-us/topic/the-net-framework-4-7-developer-pack-and-language-packs-80ad488a-bed3-3468-c9bd-4563a6f54636I double-checked execution of the fixed provision command on a freshly installed win11+vs2019, the result is OK:
Could you verify and accept my PR?