This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix gtk shapes rendering nav glitch #15171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
force-pushed
the
fixGtkShapesRenderingNavGlitch
branch
from
750fed3
to
178036c
Compare
knocte
pushed a commit
to nblockchain/DotNetForms
that referenced
this pull request
Feb 20, 2022
knocte
added a commit
to nblockchain/geewallet
that referenced
this pull request
Feb 20, 2022
Upgrading DotNetForms to pick up a proper bugfix [1] ([2]), instead of the workaround we added in previous version [3]). [1] nblockchain/DotNetForms@82e0879 [2] xamarin/Xamarin.Forms#15171 [3] d00e8d8
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
force-pushed
the
fixGtkShapesRenderingNavGlitch
branch
from
178036c
to
e76eadb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jfversluis
force-pushed
the
fixGtkShapesRenderingNavGlitch
branch
from
e76eadb
to
91abae4
Compare
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Mar 30, 2022
knocte
added a commit
to nblockchain/geewallet
that referenced
this pull request
Apr 3, 2022
Because our last PR[1] was recently merged and so I rebased our fork to follow mainline of Xamarin.Forms (only reason why we're still using DotNetForms now is, not because we have patches that are not merged yet in XF, which is not the case anymore, but because a new version of XF that contains our fixes has not yet been released). [1] xamarin/Xamarin.Forms#15171
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Queue a redraw properly when coming back from navigation-bar event.
Issues Resolved
API Changes
None
Platforms Affected
Testing Procedure
See the testcase in #15170
PR Checklist