This repository has been archived by the owner on May 1, 2024. It is now read-only.
Add gallery pages for some carouselview bugs #15250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d hosting a carouselview inside a collecitonview
|
This is definitely very useful and easier to test and track down. Thanks so much for this! |
2 tasks
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jfversluis
approved these changes
Apr 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
CarouselViewfor [Bug] [Android] CarouselView stops displaying content when source changes. #15231 (CarsouelView Gallery -> CarsouselView Replace Source)CarouselViewinCollectionViewfor CarouselView Position stops working when the collection updates #11211 is still not working #15082` (CollectionView Gallery -> CarouselView in CollectionView)Now I have these test cases, I'm going to have a look at fixing, but I figured the test cases were still useful on their own.
Incidentally, the existing CarouselView code galleries show weird behavior on Android if you update the number of items.
PR Checklist