Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] fix item indices and item count in a ListView #15306

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

heikow10
Copy link
Contributor

Description of Change

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

The TalkBack screen reader now has the correct item indices and item count for the elements in a ListView.

Before/After Screenshots

Not applicable

Testing Procedure

  • Android: description can be seen in Issue15305.cs
  • iOS: not able to test this
  • UWP: not able to test this

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis
Copy link
Member

jfversluis commented Apr 11, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heikow10
Copy link
Contributor Author

@jfversluis What will happen with this PR? It has already been built. Will it ever be merged or is something still missing to do that?

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@heikow10
Copy link
Contributor Author

heikow10 commented Jul 8, 2022

What is the problem with the build?

@jfversluis
Copy link
Member

@heikow10 don't worry about it! It's just the public build. Just verified on our private build server that this works.

Sorry it took a bit longer, thank you so much for your patience here and your contribution!

@jfversluis jfversluis merged commit 48a7087 into xamarin:5.0.0 Jul 11, 2022
@heikow10 heikow10 deleted the issue-15305 branch July 11, 2022 14:29
jfversluis added a commit that referenced this pull request Jul 14, 2022
jfversluis added a commit that referenced this pull request Jul 14, 2022
heikow10 added a commit to heikow10/Xamarin.Forms that referenced this pull request Jul 15, 2022
heikow10 added a commit to heikow10/Xamarin.Forms that referenced this pull request Jul 15, 2022
jfversluis added a commit that referenced this pull request Jul 16, 2022
* Revert "Revert "[Android] fix item indices and item count in a ListView (#15306)" (#15473)"

This reverts commit 04ace58.

* Fix scroll position in ListView on Android (#15305)

Co-authored-by: Heiko Wobst <wobst.heiko1010@t-online.de>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants