Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

GTK: Call Pixbuf ctor on MainThread for LoadImageAsync functions #15503

Merged
merged 1 commit into from
Aug 23, 2022
Merged

GTK: Call Pixbuf ctor on MainThread for LoadImageAsync functions #15503

merged 1 commit into from
Aug 23, 2022

Conversation

parhamsaremi
Copy link
Contributor

@parhamsaremi parhamsaremi commented Aug 11, 2022

This fix avoids threading problems caused by calling Pixbuf ctor from outside of the MainThread.

Description of Change

This fix avoids threading problems caused by calling Pixbuf ctor from outside of the MainThread by invoking it on the MainThread using Device.InvokeOnMainThreadAsync function.

API Changes

None

Platforms Affected

  • GTK

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

This fix avoids threading problems caused by calling Pixbuf ctor from outside of the MainThread.
@net-foundation-cla
Copy link

net-foundation-cla bot commented Aug 11, 2022

CLA assistant check
All CLA requirements met.

knocte pushed a commit to nblockchain/DotNetForms that referenced this pull request Aug 11, 2022
This fix avoid threading problems caused by calling Pixbuf ctor from outside
of the MainThread.

Upstream PR: xamarin#15503
knocte pushed a commit to nblockchain/DotNetForms that referenced this pull request Aug 12, 2022
This fix avoids threading problems caused by calling Pixbuf ctor from outside
of the MainThread.

Upstream PR: xamarin#15503
knocte added a commit to nblockchain/geewallet that referenced this pull request Aug 12, 2022
This new DotNetForms.Platform.GTK package has been generated from the
last Xamarin.Forms tag (5.0.0.2515) and includes this upstream fix:

xamarin/Xamarin.Forms#15503
@jfversluis
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jfversluis
Copy link
Member

@jfversluis jfversluis merged commit 8af69e3 into xamarin:5.0.0 Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants