This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix crash iOS Label measure for RTL languages #15605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
changed the title
# Conflicts: # build/steps/build-windows.yml
…into fix-15535
jsuarezruiz
approved these changes
Nov 15, 2022
This was referenced Nov 15, 2022
Closed
|
Hi @jfversluis , This PR is fixing the crash for some of the labels but for some labels where the Element is null, the size request is not gettig calculated. Hece the app is crashing even in latest version. This would be the edge case scenario but importat to handle as app is still crashing on iOS 16. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As of iOS 16 (or probably more likely; Xcode 14) a
NaNvalue would occur when measuring this label size. To account for that, detectNaNvalues and set it to an unknown value so it will recalculate.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist