-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[iOS] Clear prototype cell on UnevenRows #1569
Conversation
Should this be pointed at 15-5 instead of master? It's on the vCurrent board. |
build |
please make sure one of your commit says "fixes #xxx" so the squashed merge commit contains it. |
@rmarinho Expect launching iOS gallery and tapping "Go to Test Cases" works but actually fails with exception "Please provide unique tracker + issue number combo" due to existing test test case with matching issue repository and number: Xamarin.Forms/Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue1567.cs Line 13 in 74cb5c4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase to 15-5. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests. See @kingces95's comment.
Approved once test is fixed :) |
d1e0f32
to
d0d2f7b
Compare
Description of Change
We were disposing our renderers of the prototype cell so we should also just clear our prototypecell
Bugs Fixed
PR Checklist