Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Clear prototype cell on UnevenRows #1569

Merged
merged 6 commits into from
Mar 8, 2018
Merged

[iOS] Clear prototype cell on UnevenRows #1569

merged 6 commits into from
Mar 8, 2018

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Jan 12, 2018

Description of Change

We were disposing our renderers of the prototype cell so we should also just clear our prototypecell

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts changed the title Clear prototype cell on UnevenRows fixes #1567 [iOS] Clear prototype cell on UnevenRows fixes #1567 Jan 12, 2018
@samhouts
Copy link
Member

Should this be pointed at 15-5 instead of master? It's on the vCurrent board.

@rmarinho
Copy link
Member Author

build

@StephaneDelcroix
Copy link
Member

please make sure one of your commit says "fixes #xxx" so the squashed merge commit contains it.

@kingces95
Copy link
Contributor

kingces95 commented Jan 31, 2018

@rmarinho Expect launching iOS gallery and tapping "Go to Test Cases" works but actually fails with exception "Please provide unique tracker + issue number combo" due to existing test test case with matching issue repository and number:

[Issue (IssueTracker.Github, 1567, "NRE in NavigationProxy.set_Inner", PlatformAffected.iOS)]
. .

Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase to 15-5. Thanks!

@samhouts samhouts added this to Ready in v3.0.0 via automation Feb 7, 2018
@rmarinho rmarinho changed the base branch from master to 15-5 February 8, 2018 17:51
@samhouts samhouts dismissed their stale review February 8, 2018 19:01

Rebased! Thanks.

@samhouts samhouts moved this from Ready to In Review in v3.0.0 Feb 9, 2018
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing tests. See @kingces95's comment.

@samhouts samhouts changed the title [iOS] Clear prototype cell on UnevenRows fixes #1567 [iOS] Clear prototype cell on UnevenRows Feb 12, 2018
@jassmith
Copy link

Approved once test is fixed :)

@rmarinho rmarinho force-pushed the fix-1567 branch 2 times, most recently from d1e0f32 to d0d2f7b Compare February 23, 2018 11:51
@rmarinho rmarinho added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Feb 23, 2018
@samhouts samhouts moved this from In Review to In Progress in v3.0.0 Mar 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants