This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] TimePicker unfocuses on cancel #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldipietro
force-pushed
the
fix-bugzilla42074
branch
2 times, most recently
from
67e6ccd
to
475d3c5
Compare
|
👍 with passing UI tests |
pauldipietro
force-pushed
the
fix-bugzilla42074
branch
from
475d3c5
to
7f61add
Compare
|
👍waiting for UItests |
pauldipietro
force-pushed
the
fix-bugzilla42074
branch
from
7f61add
to
300b3a2
Compare
Related to the prior fix of the DatePicker not unfocusing on the cancel button being pressed, the TimePicker was not unfocusing, as well. A similar fix has been applied.
pauldipietro
force-pushed
the
fix-bugzilla42074
branch
from
300b3a2
to
04182bc
Compare
|
Updated code to fix the same issue that was occurring in #249 |
rmarinho
pushed a commit
that referenced
this pull request
Jul 13, 2016
Related to the prior fix of the DatePicker not unfocusing on the cancel button being pressed, the TimePicker was not unfocusing, as well. A similar fix has been applied.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a similar fix to #204 which needed to be adjusted to respect the cancel button being pressed on the
TimePickerdialog, as well. The control gallery reproduction and test for that issue has been duplicated and modified to check against theTimePicker.Bugs Fixed
https://bugzilla.xamarin.com/show_bug.cgi?id=42074
API Changes
None.
Behavioral Changes
None.
PR Checklist