Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fixes issue when setting NavigationPage.SetHasBackButton after page has navigated (Android/AppCompat) #256

Merged
merged 1 commit into from Jul 18, 2016

Conversation

stefandevo
Copy link

@stefandevo stefandevo commented Jul 14, 2016

Description of Change

When a page was already navigated, and you used NavigationPage.SetHasBackButton(this, false) to switch of the Back Button in Android AppCompat, the toolbar was not updated.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=42557

API Changes

None

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas
Copy link

dnfclas commented Jul 14, 2016

Hi @stefandevo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@rmarinho
Copy link
Member

👍

@stefandevo
Copy link
Author

Any idea when this will be in a "public" release?
At the moment I am using a dirty fix by adding a " " to the title (which forces the same method)

@jassmith
Copy link

👍

@jassmith jassmith merged commit d1a8477 into xamarin:master Jul 18, 2016
@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants