Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue when setting NavigationPage.SetHasBackButton after page has navigated (Android/AppCompat) #256

Merged
merged 1 commit into from Jul 18, 2016

Conversation

@stefandevo
Copy link
Contributor

commented Jul 14, 2016

Description of Change

When a page was already navigated, and you used NavigationPage.SetHasBackButton(this, false) to switch of the Back Button in Android AppCompat, the toolbar was not updated.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=42557

API Changes

None

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Copy link

commented Jul 14, 2016

Hi @stefandevo, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@rmarinho

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

👍

@stefandevo

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2016

Any idea when this will be in a "public" release?
At the moment I am using a dirty fix by adding a " " to the title (which forces the same method)

@jassmith

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2016

👍

@jassmith jassmith merged commit d1a8477 into xamarin:master Jul 18, 2016
@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.