This repository has been archived by the owner on May 1, 2024. It is now read-only.
Use explicit references so VS for Mac doesn't pick up Design files #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bholmes
reviewed
May 1, 2018
.nuspec/Xamarin.Forms.nuspec
Outdated
| @@ -105,6 +145,17 @@ | |||
| <file src="..\Xamarin.Forms.Core.Design\bin\$Configuration$\Xamarin.Forms.Core.Design.dll" target="lib\netstandard1.0\Design" /> | |||
| <file src="..\Xamarin.Forms.Xaml.Design\bin\$Configuration$\Xamarin.Forms.Xaml.Design.dll" target="lib\netstandard1.0\Design" /> | |||
|
|
|||
| <file src="..\Xamarin.Forms.Core.Design\bin\$Configuration$\Xamarin.Forms.Core.Design.dll" target="lib\MonoAndroid10\Design" /> | |||
bholmes
reviewed
May 1, 2018
.nuspec/Xamarin.Forms.nuspec
Outdated
| @@ -42,9 +42,49 @@ | |||
| <dependency id="Tizen.NET" version="4.0.0"/> | |||
| </group> | |||
| </dependencies> | |||
|
|
|||
| <references> | |||
There was a problem hiding this comment.
Mixing tabs and spaces with the rest of the file.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We don't want the files in the Design folder to be added as assembly references when installing the nuget package; to avoid this, we make the list of assembly references explicit.
Bugs Fixed