New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPF] Fixes ControlTemplate sizing issue #2656
Merged
StephaneDelcroix
merged 2 commits into
xamarin:master
from
paymicro:fix-gh2642-ControlTemplate-WPF
Oct 19, 2018
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
51 changes: 51 additions & 0 deletions
51
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/GitHub2642.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
using Xamarin.Forms.CustomAttributes; | ||
using Xamarin.Forms.Internals; | ||
|
||
namespace Xamarin.Forms.Controls.Issues | ||
{ | ||
[Preserve(AllMembers = true)] | ||
[Issue(IssueTracker.Github, 2642, "ControlTemplate resizing issue", PlatformAffected.WPF)] | ||
public class GitHub2642 : TestContentPage | ||
{ | ||
public class PresenterWrapper : ContentView | ||
{ | ||
public PresenterWrapper() | ||
{ | ||
Content = new ContentPresenter(); | ||
} | ||
} | ||
|
||
protected override void Init() | ||
{ | ||
this.ControlTemplate = new ControlTemplate(typeof(PresenterWrapper)); | ||
|
||
var grid = new Grid() | ||
{ | ||
RowDefinitions = new RowDefinitionCollection | ||
{ | ||
new RowDefinition { Height = new GridLength(0, GridUnitType.Auto) }, | ||
new RowDefinition { Height = new GridLength(1, GridUnitType.Star) }, | ||
} | ||
}; | ||
|
||
grid.AddChild(new Label() | ||
{ | ||
Text = "Header", | ||
LineBreakMode = LineBreakMode.WordWrap, | ||
FontSize = 24 | ||
|
||
}, 0, 0); | ||
|
||
grid.AddChild(new Label() | ||
{ | ||
Text = "Lorem ipsum dolor sit amet, sed at etiam graecis. Amet dicta utroque in ius, error vituperatoribus vel ex. " + | ||
"Cu duo veri aperiam honestatis. Quo sint movet ullamcorper cu, vero vidisse argumentum ne nec, in munere eirmod eum. " + | ||
"Persius similique reformidans ex mei, cu quo quot nihil mediocrem.", | ||
LineBreakMode = LineBreakMode.WordWrap | ||
|
||
}, 0, 1); | ||
|
||
Content = grid; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't you cast to
IControlTemplated
? or are you 100% sure that this only needs to be done on ContentPages ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IControlTemplated
does not define theContent
property.Only on
ContentPage
hasContent
property which we need.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about ContentView ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback.
I added check
ContentView
. Except i haven't tested it yet.