SwipeGestureRecognizer #2727

seanyda · 2018-05-15T15:50:01Z

Description of Change

Added a SwipeGestureRecognizer to Xamarin.Forms which works on iOS, Android, Windows and Tizen.

API Changes

Xamarin.Forms.Core

SwipeEventArgs.cs
SwipeGestureRecognizer.cs
SwipeDirection.cs
ISwipeGestureController.cs

Xamarin.Forms.Platform.iOS

EventTracker.cs

Xamarin.Forms.Platform.Android

GestureManager.cs
InnerGestureListener.cs
SwipeGestureHandler.cs

Xamarin.Forms.Platform.UAP

VisualElementTracker.cs

Xamarin.Forms.Platform.Tizen

GestureDetector.cs
SwipeGestureHandler.cs

Testing

SwipeGestureGalleryPage.cs
SwipeGestureRecognizerTests.cs

PR Checklist

Has tests (if omitted, state reason in description)
Rebased on top of master at time of PR
Changes adhere to coding standard
Consolidate commits as makes sense

Previous PR: #1330

seanyda · 2018-05-15T15:50:36Z

Hi All,

I had to make new PR for rebase. @samhouts @rmarinho @StephaneDelcroix

Thanks.

samhouts · 2018-05-16T23:37:13Z

Xamarin.Forms.Platform.Android/InnerGestureListener.cs

@@ -197,13 +210,15 @@ bool StartScrolling(MotionEvent e2)
 			float totalX = e2.GetX() - _lastX;
 			float totalY = e2.GetY() - _lastY;

-			return _scrollDelegate(totalX, totalY, e2.PointerCount);
+			return _scrollDelegate(totalX, totalY, e2.PointerCount) || || _swipeDelegate(totalX, totalY);


Maybe a merge error? Causing build to fail.

meant to dismiss

samhouts · 2018-05-18T01:31:16Z

New error! Error CS0169: The field 'GestureManager._tapAndPanDetector' is never used

seanyda · 2018-05-23T15:34:04Z

@samhouts What's making the iOS10 Validation fail? I'll fix it.

rmarinho · 2018-05-23T15:39:08Z

@seanyda we can ignore that failure, is not related.

SuEric · 2018-05-23T18:15:31Z

Amazing work!

Looking forward to have this on my apps! :D

@rmarinho ,
Any plans of releasing this soon? Or for what version will this be released?
I've an upcoming delivery 😅

rmarinho

we have some changes on the csproj I think we can avoid

rmarinho · 2018-05-24T10:30:04Z

Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj

@@ -43,67 +43,7 @@
    <Compile Update="GalleryPages\VisualStateManagerGalleries\OnPlatformExample.xaml.cs">
      <DependentUpon>OnPlatformExample.xaml</DependentUpon>
    </Compile>
-    <EmbeddedResource Update="GalleryPages\VisualStateManagerGalleries\ButtonDisabledStatesGallery.xaml">


Why are we dropping these files?

rmarinho · 2018-05-24T10:30:21Z

Xamarin.Forms.Core.UnitTests/Xamarin.Forms.Core.UnitTests.csproj

@@ -207,7 +208,7 @@
      <Name>Xamarin.Forms.Maps</Name>
    </ProjectReference>
    <ProjectReference Include="..\Xamarin.Forms.Platform\Xamarin.Forms.Platform.csproj">
-      <Project>{67f9d3a8-f71e-4428-913f-c37ae82cdb24}</Project>
+      <Project>{D31A6537-ED9C-4EBD-B231-A8D4FE44126A}</Project>


not sure we need this

rmarinho · 2018-05-24T10:31:09Z

Xamarin.Forms.Maps.Android/Xamarin.Forms.Maps.Android.csproj

@@ -111,6 +112,15 @@
    <Reference Include="Xamarin.Android.Support.v7.MediaRouter">
      <HintPath>..\packages\Xamarin.Android.Support.v7.MediaRouter.25.4.0.2\lib\MonoAndroid70\Xamarin.Android.Support.v7.MediaRouter.dll</HintPath>
    </Reference>
+    <Reference Include="Xamarin.GooglePlayServices.Base">


not sure we need to add this

rmarinho

sorry a couple of small changes to make the pr cleaner. Also do you think is possible to add a UITest ? it will make us more confidant that this Works in the future.

Thanks

rmarinho · 2018-05-24T13:26:32Z

Xamarin.Forms.ControlGallery.Android/Xamarin.Forms.ControlGallery.Android.csproj

@@ -250,6 +252,10 @@
    <AndroidResource Include="Resources\drawable\cover1.jpg" />
  </ItemGroup>
  <ItemGroup>
+    <ProjectReference Include="..\PagesGallery\PagesGallery.Droid\PagesGallery.Droid.csproj">


why do we have this reference ? please try to add the changes needed , it's hard because the IDE plays tricks on you

rmarinho · 2018-05-24T13:27:27Z

Xamarin.Forms.ControlGallery.Android/Xamarin.Forms.ControlGallery.Android.csproj

@@ -346,6 +352,9 @@
  <ItemGroup>
    <AndroidResource Include="Resources\drawable\red_button.xml" />
  </ItemGroup>
+  <ItemGroup>
+    <AndroidAsset Include="Assets\test.jpg" />


this asset is also not needed i think

rmarinho · 2018-05-24T13:27:55Z

Xamarin.Forms.Controls/Xamarin.Forms.Controls.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">


no changes here, please try cleanup and not submit this file

rmarinho · 2018-05-24T13:28:17Z

Xamarin.Forms.Core.UnitTests/Xamarin.Forms.Core.UnitTests.csproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>


same, no changes, don't submit this file.

rmarinho · 2018-05-24T13:29:04Z

Xamarin.Forms.Maps.Android/Xamarin.Forms.Maps.Android.csproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>


no changes, don't submit

rmarinho · 2018-05-24T13:29:16Z

Xamarin.Forms.Platform.Android.AppLinks/Xamarin.Forms.Platform.Android.AppLinks.csproj

@@ -1,4 +1,4 @@
-<?xml version="1.0" encoding="utf-8"?>
+<?xml version="1.0" encoding="utf-8"?>


same as above

rmarinho · 2018-05-24T13:29:49Z

Xamarin.Forms.Platform.Android/GestureManager.cs

@@ -129,7 +129,8 @@ GestureDetector InitializeTapAndPanDetector()

 				return new List<GestureElement>();
 			}),
-				new PanGestureHandler(() => View, context.FromPixels));
+				new PanGestureHandler(() => View, context.FromPixels),
+			    new SwipeGestureHandler(() => View, context.FromPixels));


missing space, not important

velocitysystems · 2018-09-17T19:01:06Z

@seanyda Congrats! This finally made it into XF 3.2.0. 👍

agusibrahim · 2018-09-22T16:29:42Z

thnx for this update, i love xamarin

CaLxCyMru · 2018-09-25T08:21:27Z

Awesome addition @seanyda! 👍

remmettaro · 2018-09-26T08:23:26Z

We love you so much!

SwipeGesture

f8feee5

seanyda changed the title ~~SwipeGesture~~ SwipeGestureRecognizer May 15, 2018

samhouts added this to In Review in v3.6.0 May 16, 2018

samhouts suggested changes May 16, 2018

View reviewed changes

Fix Build Error

891b62c

samhouts previously approved these changes May 18, 2018

View reviewed changes

Remove unused var

5d6d42b

xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label May 21, 2018

samhouts approved these changes May 23, 2018

View reviewed changes

rmarinho reviewed May 24, 2018

View reviewed changes

seanyda added 5 commits May 24, 2018 11:42

Update Xamarin.Forms.Controls.csproj

1d54725

Update Xamarin.Forms.ControlGallery.Android.csproj

ecee66b

Update Xamarin.Forms.Maps.Android.csproj

58fdd53

Update Xamarin.Forms.Core.UnitTests.csproj

8d2c273

Update Xamarin.Forms.Platform.Android.AppLinks.csproj

80bd5cc

rmarinho reviewed May 24, 2018

View reviewed changes

seanyda added 5 commits May 24, 2018 15:04

Update Xamarin.Forms.ControlGallery.Android.csproj

6a50365

Update Xamarin.Forms.Controls.csproj

7aa3ed0

Update Xamarin.Forms.ControlGallery.Android.csproj

a9d60b9

Update GestureManager.cs

bab075d

Merge branch 'master' into master

fd68fb5

xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label May 25, 2018

rmarinho merged commit 67f87df into xamarin:master May 28, 2018

v3.6.0 automation moved this from In Review to Done May 28, 2018

samhouts added the t/enhancement ➕ label Jun 11, 2018

samhouts added this to the 3.2.0 milestone Jun 26, 2018

samhouts removed this from Done in v3.6.0 Jun 26, 2018

samhouts added this to Done in v3.2.0 Jun 26, 2018

seanyda mentioned this pull request Jul 18, 2018

SwipeGestureRecognizer #880

Closed

4 tasks

samhouts mentioned this pull request Jul 30, 2018

[Android] Prevent duplicate events from SwipeGestureRecognizer #3443

Merged

3 tasks

samhouts modified the milestone: 3.2.0 Sep 12, 2018

pauldipietro mentioned this pull request Nov 1, 2018

Swipe left/right gesture #4281

Closed

rookiejava mentioned this pull request Nov 11, 2019

[Tizen] Enables SwipeGestureHandler #8456

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SwipeGestureRecognizer #2727

SwipeGestureRecognizer #2727

seanyda commented May 15, 2018 •

edited by samhouts

seanyda commented May 15, 2018

samhouts May 16, 2018

samhouts commented May 18, 2018

seanyda commented May 23, 2018

rmarinho commented May 23, 2018

SuEric commented May 23, 2018 •

edited

rmarinho left a comment

rmarinho May 24, 2018

rmarinho May 24, 2018

rmarinho May 24, 2018

rmarinho left a comment

rmarinho May 24, 2018

rmarinho May 24, 2018

rmarinho May 24, 2018

rmarinho May 24, 2018

rmarinho May 24, 2018

rmarinho May 24, 2018

rmarinho May 24, 2018

velocitysystems commented Sep 17, 2018

agusibrahim commented Sep 22, 2018

CaLxCyMru commented Sep 25, 2018

remmettaro commented Sep 26, 2018

		@@ -1,4 +1,4 @@
		<Project Sdk="Microsoft.NET.Sdk">
		<Project Sdk="Microsoft.NET.Sdk">

		@@ -1,4 +1,4 @@
		<?xml version="1.0" encoding="utf-8"?>
		<?xml version="1.0" encoding="utf-8"?>

SwipeGestureRecognizer #2727

SwipeGestureRecognizer #2727

Conversation

seanyda commented May 15, 2018 • edited by samhouts

Description of Change

API Changes

PR Checklist

seanyda commented May 15, 2018

Choose a reason for hiding this comment

samhouts commented May 18, 2018

seanyda commented May 23, 2018

rmarinho commented May 23, 2018

SuEric commented May 23, 2018 • edited

rmarinho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rmarinho left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

velocitysystems commented Sep 17, 2018

agusibrahim commented Sep 22, 2018

CaLxCyMru commented Sep 25, 2018

remmettaro commented Sep 26, 2018

seanyda commented May 15, 2018 •

edited by samhouts

SuEric commented May 23, 2018 •

edited