This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Fixes HorizontalTextAlignment not being applied to TextView Elements #2743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build --uitests |
1 similar comment
|
build --uitests |
samhouts
changed the title
|
build --uitests |
|
The tests all passed in app center even though above is not reporting it as such |
samhouts
added
the
retarget-branch-required
samhouts
approved these changes
May 17, 2018
…ontal Alignment
PureWeen
added
3.0.0
p/Android
and removed
retarget-branch-required
StephaneDelcroix
approved these changes
May 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Still set the TextView.Gravity property based on the Horizontal Alignment
In my testing just setting TextAlignment was unreliable. For example in the ControlGallery project it works fine but if you create a new XF project and try to set the HorizontalTextAlignment there on an Entry field it wouldn't work.
In the latter case whenever the View.TextAlignment was set to Center android was just reverting it back to Gravity.
Caused by #1222.
Bugs Fixed
fixes #2167
PR Checklist