[Android] Fix NRE When Scrolling ListView and Item With Context Actions Is Selected #310

Merged
merged 2 commits into from Oct 17, 2016

Conversation

Projects
None yet
5 participants
@jimmgarrido
Collaborator

jimmgarrido commented Aug 19, 2016

Description of Change

This fixes an NRE that was being thrown when scrolling the ListView when an item with context actions was selected. It turns out this bit of code was being called after all contrary to the original comment.

Bugs Fixed

API Changes

None

Behavioral Changes

Doesn't appear to be any. Removing the code doesn't seem to affect the cell rendering.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Aug 19, 2016

Hi @jimmgarrido, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

dnfclas commented Aug 19, 2016

Hi @jimmgarrido, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Aug 20, 2016

Member

Can you add a UITest?

Member

rmarinho commented Aug 20, 2016

Can you add a UITest?

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Aug 28, 2016

@jimmgarrido, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

dnfclas commented Aug 28, 2016

@jimmgarrido, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas dnfclas added the cla-signed label Aug 28, 2016

@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Aug 30, 2016

Member

Need to dig through history and see why this was added.

Member

jassmith commented Aug 30, 2016

Need to dig through history and see why this was added.

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Sep 27, 2016

Member

@jassmith it was in your fix for https://bugzilla.xamarin.com/show_bug.cgi?id=39476 here xamarin/Duplo#3698

@jimmgarrido can you check if this doesn't regress this bug again ?! Thanks

Member

rmarinho commented Sep 27, 2016

@jassmith it was in your fix for https://bugzilla.xamarin.com/show_bug.cgi?id=39476 here xamarin/Duplo#3698

@jimmgarrido can you check if this doesn't regress this bug again ?! Thanks

@jimmgarrido

This comment has been minimized.

Show comment
Hide comment
@jimmgarrido

jimmgarrido Sep 27, 2016

Collaborator

@rmarinho This fix does not regress b#39476. I can actually reproduce the issue this PR fixes with the sample project in b#39476 even after updating to the latest Forms.

Collaborator

jimmgarrido commented Sep 27, 2016

@rmarinho This fix does not regress b#39476. I can actually reproduce the issue this PR fixes with the sample project in b#39476 even after updating to the latest Forms.

@rmarinho

This comment has been minimized.

Show comment
Hide comment
@rmarinho

rmarinho Oct 12, 2016

Member

Needs rebase

Member

rmarinho commented Oct 12, 2016

Needs rebase

@rmarinho rmarinho merged commit aa969f3 into xamarin:master Oct 17, 2016

@jimmgarrido jimmgarrido referenced this pull request Oct 19, 2016

Merged

Fix UITest for b#42832 #471

3 of 4 tasks complete

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment