[Android] Fix NRE When Scrolling ListView and Item With Context Actions Is Selected

[jimmgarrido]

Description of Change

This fixes an NRE that was being thrown when scrolling the ListView when an item with context actions was selected. It turns out this bit of code was being called after all contrary to the original comment.

Bugs Fixed

• https://bugzilla.xamarin.com/show_bug.cgi?id=42832

API Changes

None

Behavioral Changes

Doesn't appear to be any. Removing the code doesn't seem to affect the cell rendering.

PR Checklist

• Has tests (if omitted, state reason in description)
• Rebased on top of master at time of PR
• Changes adhere to coding standard
• Consolidate commits as makes sense

[dnfclas]

Hi @jimmgarrido, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

[rmarinho]

Can you add a UITest?

[dnfclas]

@jimmgarrido, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

[jassmith]

Need to dig through history and see why this was added.

[rmarinho]

@jassmith it was in your fix for https://bugzilla.xamarin.com/show_bug.cgi?id=39476 here https://github.com/xamarin/Duplo/pull/3698

@jimmgarrido can you check if this doesn't regress this bug again ?! Thanks

[jimmgarrido]

@rmarinho This fix does not regress b#39476. I can actually reproduce the issue this PR fixes with the sample project in b#39476 even after updating to the latest Forms.

[rmarinho]

Needs rebase