Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Add a CheckBox. #323

Closed
wants to merge 1 commit into from
Closed

Add a CheckBox. #323

wants to merge 1 commit into from

Conversation

yourina
Copy link
Contributor

@yourina yourina commented Aug 26, 2016

Description of Change

Add a CheckBox Control to Xamarin.Forms.
A CheckBox is a specific control that has two states which are 'checked' and 'unchecked'.
A CheckBox allows the user to select multiple options among several items in a list.

Bugs Fixed

N/A

API Changes

A CheckBox Control has the following properties and event.:

Added:

  • String Text { get; set; } A value for the text that is displayed as the content of the CheckBox. This is a bindable property.
  • Color TextColor { get; set; } A value that indicates the color for the text of CheckBox. This is a bindable property.
  • Font Font { get; set; } A value that indicates the font of the CheckBox. This is a bindable property.
  • FontAttributes FontAttributes { get; set; } A value that indicates whether the font of the CheckBox is bold, italic or neither. This is a bindable property.
  • String FontFamily { get; set; } A value that indicates the font family which the CheckBox font belongs to. This is a bindable property.
  • Double FontSize { get; set; } A value that indicates the font size of the CheckBox. This is a bindable property.
  • bool IsChecked { get; set; } A value that indicates whether the CheckBox is checked or not. This is a bindable property.
  • event EventHandler Checked This event occurs when the CheckBox is checked or unchecked.

Behavioral Changes

N/A

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@dnfclas
Copy link

dnfclas commented Aug 26, 2016

Hi @yourina, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@rmarinho
Copy link
Member

Hi thanks for your contribution. This is a good start, but it needs more work.
A couple of suggestions:

  • Add unit tests, a gallery page on the ControlGallery , if possible UITests for iOS and Android.
  • Needs a iOS implementation
  • Rebase the project.
  • Fix indentation issues

Please reopen with good for another review.

@rmarinho rmarinho closed this Sep 27, 2016
@weitzhandler
Copy link

Related #1728.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants