Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[macOS] Navigating back from a complex page is highly inefficient #3406

Merged
merged 4 commits into from Aug 7, 2018
Merged

[macOS] Navigating back from a complex page is highly inefficient #3406

merged 4 commits into from Aug 7, 2018

Conversation

slakul
Copy link
Contributor

@slakul slakul commented Jul 26, 2018 •
edited by samhouts

Description of Change

The recursion in DisposeModelAndChildrenRenderers method (Xamarin.Forms.Platform.MacOS/Platform.cs) has been improved.

Issues Resolved

API Changes

None

Platforms Affected

  • macOS

Behavioral/Visual Changes

An application has better responsiveness.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@dnfclas
Copy link

dnfclas commented Jul 26, 2018 •
edited

CLA assistant check
All CLA requirements met.

@samhouts samhouts added this to In Review in v3.6.0 Jul 26, 2018
@samhouts samhouts changed the title fixes #3001 [macOS] Navigating back from a complex page is highly ine… fixes #3001 [macOS] Navigating back from a complex page is highly inefficient Jul 26, 2018
samhouts
samhouts previously requested changes Jul 26, 2018
View reviewed changes
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue3001.cs(81,44): Error CS1739: The best overload for 'Tap' does not have a parameter named 'timeout'

@samhouts samhouts changed the title fixes #3001 [macOS] Navigating back from a complex page is highly inefficient [macOS] Navigating back from a complex page is highly inefficient Jul 26, 2018
@slakul
Copy link
Contributor Author

slakul commented Jul 29, 2018

@samhouts - I have fixed the compilation error in the last commit.

@rmarinho rmarinho merged commit 24c6e3b into xamarin:master Aug 7, 2018
v3.6.0 automation moved this from In Review to Done Aug 7, 2018
@slakul slakul deleted the fix-gh3001 branch August 13, 2018 09:12
PureWeen pushed a commit that referenced this pull request Aug 28, 2018
@PureWeen
[macOS] Navigating back from a complex page is highly inefficient (#3406
286fb65 
) fixes #3001

* fixes #3001 [macOS] Navigating back from a complex page is highly inefficient

* fixes UITEST compilation
@samhouts samhouts added this to the 3.3.0 milestone Sep 20, 2018
@samhouts samhouts removed this from Done in v3.6.0 Sep 21, 2018
@samhouts samhouts added this to Done in v3.4.0 Sep 21, 2018
@samhouts samhouts added e/5 🕔 5 i/low Has trivial workaround; affects very few users p/macOS t/bug 🐛 and removed e/5 🕔 5 i/low Has trivial workaround; affects very few users p/macOS labels Sep 28, 2018
@samhouts samhouts added e/5 🕔 5 i/low Has trivial workaround; affects very few users p/macOS labels Nov 2, 2018
@samhouts samhouts removed this from Done in v3.4.0 Nov 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@samhouts samhouts samhouts left review comments

Assignees
No one assigned
Labels
e/5 🕔 5 i/low Has trivial workaround; affects very few users p/macOS t/bug 🐛
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

[macOS] Navigating back from a complex page is highly inefficient
4 participants
@slakul @dnfclas @rmarinho @samhouts