Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Fix sizing issue on MDP #3515

Merged
merged 2 commits into from
Aug 15, 2018
Merged

[iOS] Fix sizing issue on MDP #3515

merged 2 commits into from
Aug 15, 2018

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Aug 8, 2018

Description of Change

Reverting some changes done on #1222 .

Start portrait , rotate to landscape , rotate portrait and rotate to landscape again.

Before:
simulator screen shot - ipad 5th generation - 2018-08-09 at 15 52 16

After:
simulator screen shot - ipad 5th generation - 2018-08-09 at 15 36 05

Issues Resolved

Platforms Affected

  • iOS

Behavioral/Visual Changes

After several rotations on iPad the Master page on MDP should always be visible

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts added this to In Review in v3.2.0 Aug 8, 2018
@rmarinho rmarinho added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 8, 2018
@rmarinho rmarinho force-pushed the fix-3458 branch 2 times, most recently from 6098a81 to 1f1e7eb Compare August 9, 2018 14:25
@rmarinho rmarinho changed the title [iOS] Revert flow direction changes to fix sizing issue [iOS] Fix sizing issue on MDP Aug 9, 2018
@rmarinho
Copy link
Member Author

rmarinho commented Aug 9, 2018

simulator screen shot - ipad 5th generation - 2018-08-09 at 15 16 53

simulator screen shot - ipad 5th generation - 2018-08-09 at 15 16 44

simulator screen shot - ipad 5th generation - 2018-08-09 at 15 16 34

@rmarinho rmarinho removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 9, 2018
@rmarinho rmarinho merged commit 689a0bb into 3.2.0 Aug 15, 2018
v3.2.0 automation moved this from In Review to Done Aug 15, 2018
@samhouts samhouts added this to the 3.2.0 milestone Sep 11, 2018
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Sep 11, 2018
@samhouts samhouts modified the milestone: 3.2.0 Sep 12, 2018
@StephaneDelcroix StephaneDelcroix deleted the fix-3458 branch December 19, 2018 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Has two approvals, no pending reviews, and no changes requested e/4 🕓 4 i/regression p/iOS 🍎 t/bug 🐛
Projects
No open projects
v3.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants