This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] Change CALayer.Transform in MainThread #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a UITest? or a sample in the galley?! Thanks |
|
@rmarinho yes, sure, i will do in 5-6 hours |
StephaneDelcroix
changed the title
StephaneDelcroix
approved these changes
Oct 22, 2018
|
@rmarinho done. Added test case |
AndreiMisiukevich
force-pushed
the
fix_1480
branch
from
2c512b4
to
e1065ec
Compare
|
@AndreiMisiukevich that's not really testing, Maybe add a label to the same page, and assert that label is there (it didn't crashed). Thanks |
|
@rmarinho i will set any source to WebView and add label to the top of the page |
samhouts
previously requested changes
Oct 23, 2018
Co-Authored-By: AndreiMisiukevich <andrei.misiukevich@gmail.com>
|
@samhouts done. You may review again |
|
build --uitests |
samhouts
approved these changes
Oct 31, 2018
PureWeen
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Confirm changing CALayer.Transform in Main Thread
Issues Resolved
API Changes