[iOS] fix for SearchBar background color #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase to fix conflict please? |
andreinitescu
force-pushed
the
fix-4194-SearchBar
branch
from
97d4ff6
to
b9a12db
Compare
|
@PureWeen Sure, done! |
hartez
reviewed
Oct 30, 2018
| @@ -120,8 +120,7 @@ protected override void SetBackgroundColor(Color color) | |||
|
|
|||
| Control.BarTintColor = color.ToUIColor(_defaultTintColor); | |||
|
|
|||
| if (color.A < 1) | |||
There was a problem hiding this comment.
@rmarinho Do you remember why this if statement was here? It came from https://github.com/xamarin/Duplo/pull/3265 and https://github.com/xamarin/Duplo/pull/3304 (fixes for https://bugzilla.xamarin.com/show_bug.cgi?id=31669).
There was a problem hiding this comment.
@hartez My take on the logic for the if is this: if there's any transparency set on the color, clear the background image so that the tint color actually uses that color with alpha, otherwise it won't work. I think the idea was that clearing the background image is not necessary otherwise, and just setting the BarTintColor should work, but it looks like it doesn't always. Not sure if this helps.
hartez
approved these changes
Nov 6, 2018
PureWeen
requested changes
Nov 8, 2018
There was a problem hiding this comment.
Build error. Possibly from a bad merge?
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Xamarin.Forms.Controls.Issues.Shared.projitems(1056,3): Error MSB4067: The element <Folder> beneath element <Project> is unrecognized.
|
build |
PureWeen
approved these changes
Nov 13, 2018
hartez
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On iOS, if a
SearchBaris created withIsVisible="false"and aBackgroundColor, after it's made later made visible by settingIsVisibletotrue, the background color is darkened.What's interesting is that if the
SearchBaris put right as a child of thePage, the issue doesn't appear. Issue only appears whenSearchBaris inside a container likeGridorStackLayoutThis fix makes ensures the background image is always cleared so that the color set by BarTintColor is always reflected in the
SearchBarlook. Per my investigation, without always setting the background image, it looks like there are some issues sometimes with UISearchBar. Not sure if it's completely related but I stumbled on thisIssues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
See description and screenshots
Before/After Screenshots
Before:
After:
Testing Procedure
I added a test page for this issue with instructions.
PR Checklist