Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[MacOs] Image from file not getting searched in the bundle #4247

Merged
merged 1 commit into from Oct 30, 2018

Conversation

AndreiMisiukevich
Copy link
Contributor

@AndreiMisiukevich AndreiMisiukevich commented Oct 28, 2018

Description of Change

Implement possibility to set FileImageSource without setting extension (you can set "image" instead of "image.png")
Added Log warning, if images wasn't found

Issues Resolved

API Changes

None

Platforms Affected

  • MacOs

Behavioral/Visual Changes

Images is shown

Before/After Screenshots

Not applicable
(Without fix you don't see the image, but if you apply it you will see the image)

Testing Procedure

new ContentPage { Content = new Image { Source = "image" } } ;

@AndreiMisiukevich AndreiMisiukevich changed the title [MacOs] [MacOs] Image from file not getting searched in the bundle Oct 28, 2018
@samhouts samhouts added this to In Review in v3.6.0 Oct 29, 2018
@samhouts
Copy link
Member

build

@rmarinho rmarinho merged commit 91dc760 into xamarin:master Oct 30, 2018
v3.6.0 automation moved this from In Review to Done Oct 30, 2018
@samhouts samhouts added the e/3 🕒 3 label Nov 2, 2018
@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018
@AndreiMisiukevich AndreiMisiukevich deleted the fix_2322 branch December 17, 2018 22:14
@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019
@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019
@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
v3.5.0
  
Done
Development

Successfully merging this pull request may close these issues.

[MacOS] Image from file not getting searched in the bundle
4 participants