Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[iOS] Removed custom entitlements entry for test simulator builds #4257

Merged
merged 1 commit into from Nov 1, 2018

Conversation

AndreiMisiukevich
Copy link
Contributor

@AndreiMisiukevich AndreiMisiukevich commented Oct 30, 2018

Description of Change

Removed custom entitlements entry for test simulator builds.
Everybody will be able debug test project easily without necessity to disable it in test project.

Issues Resolved

Now i can't build project as is.

API Changes

None

Platforms Affected

  • iOS test project

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Remove your iOS provision profile and try to start debugging of Xamarin.Forms.ControlGallery.iOS

@PureWeen PureWeen changed the title [Housekeeping][iOS] Removed custom entitlements entry for test simulator builds [iOS] Removed custom entitlements entry for test simulator builds Oct 30, 2018
@AndreiMisiukevich
Copy link
Contributor Author

@PureWeen seems, it isn't enhancement) just internal change

@PureWeen PureWeen added t/housekeeping ♻︎ Internal only changes, won't be included in release notes and removed t/enhancement ➕ labels Oct 30, 2018
@PureWeen PureWeen added this to In Review in v3.6.0 Oct 30, 2018
Copy link
Contributor

@kingces95 kingces95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only need signing if the app wants out of it's sandbox (want's entitlements). Our gallery app doesn't ask for anything (empty plist) so there's no need for signing. So remove away!

@PureWeen PureWeen removed the request for review from hartez November 1, 2018 16:07
@PureWeen PureWeen merged commit e6d0600 into xamarin:master Nov 1, 2018
v3.6.0 automation moved this from In Review to Done Nov 1, 2018
@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018
@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019
@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019
@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest 🍻 p/iOS 🍎 t/housekeeping ♻︎ Internal only changes, won't be included in release notes
Projects
No open projects
v3.5.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants