This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Convert android projects to package reference #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
added
p/Android
t/housekeeping ♻︎
kingces95
reviewed
Nov 5, 2018
There was a problem hiding this comment.
Should we also follow up with PackageReferences for all the other platforms? I could see rolling this out one by one to make it more digestible but it'd be a shame if we end up using a mix of old and new nuget references strategies.
Anyway, looks like we're having some build issues.
That was my plan. I just really want the android projects that depend on large sets of nugets upgraded to make it easier and I didn't want this PR to stall on other things. |
PureWeen
added
the
DO-NOT-MERGE-!!! 🛑
PureWeen
removed
the
DO-NOT-MERGE-!!! 🛑
rmarinho
approved these changes
Nov 6, 2018
PureWeen
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Converting Android projects over to package reference. Because of the support libraries, Android has the most interlaced nuget dependencies so getting it converted over to Package Reference makes dealing with those dependencies much easier. I've recently been needing to iterate through support libraries to test out new v28 features and having everything package reference will make this much simpler
Platforms Affected
Testing Procedure
As long as the UI Tests all pass this change should be fine
PR Checklist