Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Material] [Android, iOS] Added Slider and ProgressBar #5209

Merged
merged 3 commits into from Feb 13, 2019

Conversation

mattleibow
Copy link
Contributor

@mattleibow mattleibow commented Feb 12, 2019

Description of Change

Added the Material versions of the ProgressBar and Slider.

Issues Resolved

API Changes

Added the Material renderers for Slider and ProgressBar for Android and iOS.

The rules for the coloring are as follows:

  • All default colors, then use the defaults
  • A single color for ProgressBar.ProgressColor or Slider.MinimumTrackColor, then follow material: a single color throughout (including the slider thumb), but the background has an alpha
  • A single background color for ProgressBar.BackgroundColor or Slider.MaximumTrackColor, then just set the background color
  • Both progress and background, then throw material out and set colors explicitly
  • A default slider thumb, then fall back to the primary color
  • A specific thumb, then use that explicitly

Platforms Affected

  • iOS
  • Android

Behavioral/Visual Changes

New Material renderers.

Before/After Screenshots

Android iOS
Defaults
Height of 50
Primary color of Red
Primary and Background
All
All with 50% alpha

Testing Procedure

Loads of buttons and switches on the MaterialProgressBarGallery gallery or "[Material] ProgressBar & Slider Gallery".

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

paymicro and others added 2 commits February 7, 2019 03:00
Merging into the material "slider" / "progress" bar branch so that we can share some code as they are the same control
@mattleibow mattleibow changed the base branch from master to 3.6.0 February 12, 2019 03:28
@PureWeen PureWeen self-assigned this Feb 12, 2019
@samhouts samhouts added this to In Review in v3.6.0 Feb 12, 2019
@samhouts samhouts added this to Ready for Review (PRs) in Sprint 148 Feb 12, 2019
Copy link
Contributor

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! The testing page is awesome

It seems like some of the Color Pickers in the gallery should start on the left not the right. When you first move any of the settings the bars vanish because everything is cranked up to white by default so if you move anything then it all just vanishes

@PureWeen
Copy link
Contributor

Failing tests unrelated

@paymicro
Copy link
Contributor

[Android] All with 50% alpha
image
I think the lines should be without space.

Copy link
Contributor

@paymicro paymicro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@samhouts samhouts merged commit 9ab1fff into 3.6.0 Feb 13, 2019
v3.6.0 automation moved this from In Review to Done Feb 13, 2019
Sprint 148 automation moved this from Ready for Review (PRs) to Done Feb 13, 2019
@samhouts samhouts deleted the mattleibow/material-slider branch February 13, 2019 23:37
@mattleibow
Copy link
Contributor Author

@paymicro thanks for pointing out the weird thing. I for got to mention it on this PR.
As far as I can see, this is not something that most people would do, and if they do, the shouldn't 😄Unless we are going to make time for a custom slider... in addition to the progress bar.

@samhouts samhouts modified the milestones: 4.0.0, 3.6.0 Feb 20, 2019
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Mar 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/visual retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. t/enhancement ➕
Projects
No open projects
Sprint 148
  
Done
v3.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants