[Material] [Android, iOS] Added Slider and ProgressBar #5209
Conversation
Merging into the material "slider" / "progress" bar branch so that we can share some code as they are the same control
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! The testing page is awesome
It seems like some of the Color Pickers in the gallery should start on the left not the right. When you first move any of the settings the bars vanish because everything is cranked up to white by default so if you move anything then it all just vanishes
Failing tests unrelated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@paymicro thanks for pointing out the weird thing. I for got to mention it on this PR. |
Description of Change
Added the Material versions of the ProgressBar and Slider.
Issues Resolved
API Changes
Added the Material renderers for Slider and ProgressBar for Android and iOS.
The rules for the coloring are as follows:
ProgressBar.ProgressColor
orSlider.MinimumTrackColor
, then follow material: a single color throughout (including the slider thumb), but the background has an alphaProgressBar.BackgroundColor
orSlider.MaximumTrackColor
, then just set the background colorPlatforms Affected
Behavioral/Visual Changes
New Material renderers.
Before/After Screenshots
Testing Procedure
Loads of buttons and switches on the
MaterialProgressBarGallery
gallery or "[Material] ProgressBar & Slider Gallery".PR Checklist