New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Material] [Android, iOS] Added Slider and ProgressBar #5209

Merged
merged 3 commits into from Feb 13, 2019

Conversation

@mattleibow
Copy link
Contributor

mattleibow commented Feb 12, 2019

Description of Change

Added the Material versions of the ProgressBar and Slider.

Issues Resolved

API Changes

Added the Material renderers for Slider and ProgressBar for Android and iOS.

The rules for the coloring are as follows:

  • All default colors, then use the defaults
  • A single color for ProgressBar.ProgressColor or Slider.MinimumTrackColor, then follow material: a single color throughout (including the slider thumb), but the background has an alpha
  • A single background color for ProgressBar.BackgroundColor or Slider.MaximumTrackColor, then just set the background color
  • Both progress and background, then throw material out and set colors explicitly
  • A default slider thumb, then fall back to the primary color
  • A specific thumb, then use that explicitly

Platforms Affected

  • iOS
  • Android

Behavioral/Visual Changes

New Material renderers.

Before/After Screenshots

Android iOS
Defaults
Height of 50
Primary color of Red
Primary and Background
All
All with 50% alpha

Testing Procedure

Loads of buttons and switches on the MaterialProgressBarGallery gallery or "[Material] ProgressBar & Slider Gallery".

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

paymicro and others added some commits Feb 7, 2019

[Android Material] Linear Progress Indicator (#5079)
Merging into the material "slider" / "progress" bar branch so that we can share some code as they are the same control

@mattleibow mattleibow added the a/visual label Feb 12, 2019

@mattleibow mattleibow self-assigned this Feb 12, 2019

@mattleibow mattleibow requested review from hartez , PureWeen and paymicro Feb 12, 2019

@mattleibow mattleibow requested a review from StephaneDelcroix as a code owner Feb 12, 2019

@mattleibow mattleibow changed the base branch from master to 3.6.0 Feb 12, 2019

@PureWeen PureWeen self-assigned this Feb 12, 2019

@samhouts samhouts added this to In Review in vNext (3.6.0) Feb 12, 2019

@samhouts samhouts added this to Ready for Review (PRs) in Sprint 148 Feb 12, 2019

@PureWeen
Copy link
Contributor

PureWeen left a comment

Looks great! The testing page is awesome

It seems like some of the Color Pickers in the gallery should start on the left not the right. When you first move any of the settings the bars vanish because everything is cranked up to white by default so if you move anything then it all just vanishes

@PureWeen

This comment has been minimized.

Copy link
Contributor

PureWeen commented Feb 13, 2019

Failing tests unrelated

@paymicro

This comment has been minimized.

Copy link
Collaborator

paymicro commented Feb 13, 2019

[Android] All with 50% alpha
image
I think the lines should be without space.

@paymicro
Copy link
Collaborator

paymicro left a comment

Looks great!

@samhouts samhouts merged commit 9ab1fff into 3.6.0 Feb 13, 2019

7 of 12 checks passed

VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Running
Details
VSTS: Android API25 Validation Legacy Renderers UITests Running
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS12 Validation UITests Finished
Details
license/cla All CLA requirements met.
Details

vNext (3.6.0) automation moved this from In Review to Done Feb 13, 2019

Sprint 148 automation moved this from Ready for Review (PRs) to Done Feb 13, 2019

@samhouts samhouts deleted the mattleibow/material-slider branch Feb 13, 2019

@mattleibow

This comment has been minimized.

Copy link
Contributor Author

mattleibow commented Feb 14, 2019

@paymicro thanks for pointing out the weird thing. I for got to mention it on this PR.
As far as I can see, this is not something that most people would do, and if they do, the shouldn't 😄Unless we are going to make time for a custom slider... in addition to the progress bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment