Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

fix changed apis #5426

Merged
merged 5 commits into from Mar 2, 2019
Merged

fix changed apis #5426

merged 5 commits into from Mar 2, 2019

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Mar 1, 2019 •
edited by samhouts

Description of Change

  • Fix API changes

Issues Resolved

API Changes

  • added back default handler for HandlerAttribute
  • set UpdateTextColor, UpdatePlaceHolderText, UpdateFont, UpdatePlaceholderColor, UpdateColor on the EntryRenderers to protected so they are exposed to the world
  • add back public PickerEditText(Context context, IPickerRenderer pickerRenderer) : this(context)
  • add back public static void ApplyKeyboard(this IUITextInput textInput, Keyboard keyboard)
  • add back public static UIKit.UIBarButtonItem ToUIBarButtonItem(this Xamarin.Forms.ToolbarItem item, bool forceName)

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android

@PureWeen PureWeen requested a review from samhouts March 1, 2019 22:09
@samhouts samhouts added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Mar 1, 2019
@samhouts samhouts requested a review from kingces95 March 1, 2019 22:41
kingces95
kingces95 reviewed Mar 1, 2019
View reviewed changes
Copy link
Contributor

@kingces95 kingces95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wanna get a sanity check that those members we're making private protected that used to be internal protected were never exposed in a stable as the latter.

Xamarin.Forms.Core/HandlerAttribute.cs Show resolved Hide resolved
Xamarin.Forms.Material.Android/MaterialEntryRenderer.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Platform.iOS/Renderers/EntryRenderer.cs Outdated Show resolved Hide resolved
@samhouts samhouts added this to In Review in v3.6.0 Mar 1, 2019
@samhouts samhouts added the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Mar 1, 2019
@samhouts samhouts added this to Ready for Review (PRs) in Sprint 149 Mar 1, 2019
@samhouts samhouts added retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. and removed retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. labels Mar 2, 2019
@samhouts samhouts merged commit f1660e8 into 3.6.0 Mar 2, 2019
v3.6.0 automation moved this from In Review to Done Mar 2, 2019
Sprint 149 automation moved this from Ready for Review (PRs) to Done Mar 2, 2019
@samhouts samhouts deleted the api_fixes branch March 2, 2019 03:15
@samhouts samhouts moved this from Done to In Review in v3.6.0 Mar 2, 2019
@samhouts samhouts moved this from In Review to Done in v3.6.0 Mar 4, 2019
@samhouts samhouts added this to the 3.6.0 milestone Mar 5, 2019
@samhouts samhouts added breaking Changes behavior or appearance t/bug 🐛 i/regression labels Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samhouts samhouts samhouts approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

@kingces95 kingces95 Awaiting requested review from kingces95

Assignees

@kingces95 kingces95

@samhouts samhouts

Labels
a/shell 🐚 a/visual blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. breaking Changes behavior or appearance i/regression p/Android p/iOS 🍎 retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. t/bug 🐛
Projects
No open projects
Sprint 149
  
Done
v3.6.0
  
Done
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PureWeen @kingces95 @samhouts