[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual #5453

rookiejava · 2019-03-05T11:34:19Z

Description of Change

Added the Xamarin.Forms.Material.Tizen project for supporting Visual on Tizen. This PR includes the following material renderers.

Material ProgressBar
Material Slider
Material Frame

Issues Resolved

fixes for Tizen [Material] Linear Progress Indicator #5008
fixes for Tizen [Material] [Android, iOS] Slider Spec #5018

API Changes

None

Platforms Affected

Tizen

Behavioral/Visual Changes

New material renderers for tizen.

Before/After Screenshots

Testing Procedure

Use VisualGallery inside ControlGallery.

PR Checklist

Has automated tests
Rebased on top of the target branch at time of PR
Changes adhere to coding standard

StephaneDelcroix · 2019-03-14T12:30:38Z

Xamarin.Forms.Material.Android/MaterialColors.cs

@@ -8,16 +8,23 @@
 using ASeekBar = Android.Widget.AbsSeekBar;
 using PlatformColor = Android.Graphics.Color;
 using Xamarin.Forms.Platform.Android;
-#else
+#elif __IOS__


are we sure about this ? iOS does uses this project ?

well... I think so. I just followed the existing condition. 😉

rookiejava · 2019-04-09T09:29:00Z

If this PR can be merged sooner, it will help us proceed with the next step. 😉

PureWeen

Running through CI build real quick then I'll merge

PureWeen · 2019-04-09T15:36:57Z

@rookiejava The OSX build part of the CI is throwing the following errors

"/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj" (default target) (44) ->
  MaterialFrameRenderer.cs(8,12): error CS0246: The type or namespace name 'ExportRendererAttribute' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialFrameRenderer.cs(8,12): error CS0246: The type or namespace name 'ExportRenderer' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialProgressBarRenderer.cs(7,12): error CS0246: The type or namespace name 'ExportRendererAttribute' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialProgressBarRenderer.cs(7,12): error CS0246: The type or namespace name 'ExportRenderer' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialSliderRenderer.cs(7,12): error CS0246: The type or namespace name 'ExportRendererAttribute' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialSliderRenderer.cs(7,12): error CS0246: The type or namespace name 'ExportRenderer' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialFrameRenderer.cs(6,39): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialFrameRenderer.cs(2,30): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialProgressBarRenderer.cs(5,39): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialProgressBarRenderer.cs(2,30): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialSliderRenderer.cs(5,39): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialSliderRenderer.cs(2,30): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  Native/MBox.cs(3,30): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  Native/MCanvas.cs(3,30): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  /Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Android/MaterialColors.cs(18,30): error CS0234: The type or namespace name 'Tizen' does not exist in the namespace 'Xamarin.Forms.Platform' (are you missing an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialProgressBarRenderer.cs(10,45): error CS0246: The type or namespace name 'ProgressBarRenderer' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialSliderRenderer.cs(10,40): error CS0246: The type or namespace name 'SliderRenderer' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialFrameRenderer.cs(11,39): error CS0246: The type or namespace name 'ViewRenderer<,>' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  Native/MCanvas.cs(9,31): error CS0246: The type or namespace name 'IContainable<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  Native/MBox.cs(17,29): error CS0246: The type or namespace name 'LayoutEventArgs' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialProgressBarRenderer.cs(12,44): error CS0246: The type or namespace name 'ElementChangedEventArgs<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialSliderRenderer.cs(12,44): error CS0246: The type or namespace name 'ElementChangedEventArgs<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialFrameRenderer.cs(19,44): error CS0246: The type or namespace name 'ElementChangedEventArgs<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialSliderRenderer.cs(12,27): error CS0115: 'MaterialSliderRenderer.OnElementChanged(ElementChangedEventArgs<Slider>)': no suitable method found to override [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialFrameRenderer.cs(19,27): error CS0115: 'MaterialFrameRenderer.OnElementChanged(ElementChangedEventArgs<Frame>)': no suitable method found to override [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  MaterialProgressBarRenderer.cs(12,27): error CS0115: 'MaterialProgressBarRenderer.OnElementChanged(ElementChangedEventArgs<ProgressBar>)': no suitable method found to override [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]
  Native/MCanvas.cs(11,12): error CS0246: The type or namespace name 'ObservableCollection<>' could not be found (are you missing a using directive or an assembly reference?) [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Material.Tizen/Xamarin.Forms.Material.Tizen.csproj]

    90 Warning(s)
    28 Error(s)

rookiejava · 2019-04-10T00:47:20Z

@PureWeen It seems related #4646. So, just like this, I've updated solution file (.sln) to make don't build it on iPhone and iPhoneSimulator. Could you check it again?

PureWeen · 2019-04-10T19:32:36Z

@rookiejava

One more small fix it looks like

"/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.sln" (default target) (1) ->
"/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Platform.MacOS/Xamarin.Forms.Platform.MacOS.csproj" (default target) (33) ->
(CoreCompile target) -> 
  /Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Platform.iOS/Extensions/LabelExtensions.cs(111,4): error CS0618: 'NSLayoutManager.CharacterRangeForGlyphRange(NSRange, out NSRange)' is obsolete: 'Use 'GetCharacterRange' instead.' [/Users/vsts/agent/2.149.2/work/1/s/Xamarin.Forms.Platform.MacOS/Xamarin.Forms.Platform.MacOS.csproj]

    93 Warning(s)
    1 Error(s)

rookiejava · 2019-04-11T00:47:17Z

@PureWeen
If I understand correctly, this error is already resolved in #5613 and is not related to this PR. Do I need to rebase with the latest code?

PureWeen · 2019-04-11T00:50:00Z

@rookiejava yea if you could rebase that would be awesome!

It'd be ideal just to be sure this all compiles with the latest master build.

rookiejava · 2019-04-11T00:54:43Z

OK. I've just rebased.

PureWeen · 2019-04-11T17:23:06Z

@rookiejava

The nuget command failed with exit code(1) and error(System.IO.DirectoryNotFoundException: Could not find a part of the path 'D:\a\1\s\Xamarin.Forms.Material.Tizen\bin\Debug\tizen40'.
   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileSystemEnumerableIterator`1.CommonInit()
   at System.IO.FileSystemEnumerableIterator`1..ctor(String path, String originalUserPath, String searchPattern, SearchOption searchOption, SearchResultHandler`1 resultHandler, Boolean checkHost)
   at System.IO.Directory.GetFiles(String path, String searchPattern, SearchOption searchOption)
   at NuGet.Common.PathResolver.PerformWildcardSearch(String basePath, String searchPath, Boolean includeEmptyDirectories, String& normalizedBasePath)
   at NuGet.Packaging.PackageBuilder.ResolveSearchPattern(String basePath, String searchPath, String targetPath, Boolean includeEmptyDirectories)
   at NuGet.Packaging.PackageBuilder.AddFiles(String basePath, String source, String destination, String exclude)
   at NuGet.Packaging.PackageBuilder.PopulateFiles(String basePath, IEnumerable`1 files)
   at NuGet.Packaging.PackageBuilder.ReadManifest(Stream stream, String basePath, Func`2 propertyProvider)
   at NuGet.Packaging.PackageBuilder..ctor(String path, String basePath, Func`2 propertyProvider, Boolean includeEmptyDirectories)
   at NuGet.Commands.PackCommandRunner.CreatePackageBuilderFromNuspec(String path)
   at NuGet.Commands.PackCommandRunner.BuildFromNuspec(String path)
   at NuGet.CommandLine.PackCommand.ExecuteCommand()
   at NuGet.CommandLine.Command.ExecuteCommandAsync()
   at NuGet.CommandLine.Command.Execute()
   at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args))
An error ocurred while trying to pack the files.

rookiejava · 2019-04-12T00:16:53Z

@PureWeen
Uhm, I'm not sure but I don't think this PR directly cause this error. The modification of nuspec file doesn't look particularly strange. Could you check the configuration of the CI server or internal build script to resolve path related problem? Thank you for your support. 😃

PureWeen · 2019-04-12T00:25:47Z

Right!! I remember needing to do this with the other material.

At some point we'll have this moved all over to YAML and then we should be able to do this with the PRs
I updated the CI server but can you update the YAML file in this pr??

basically you have to add these lines

Xamarin.Forms.Material.Tizen/bin/$(BuildConfigurations)/**/*.dll
Xamarin.Forms.Material.Tizen/bin/$(BuildConfigurations)/**/*.pdb
Xamarin.Forms.Material.Tizen/bin/$(BuildConfigurations)/**/*.mdb

to this file
https://github.com/xamarin/Xamarin.Forms/blob/master/build/steps/build-windows.yml#L61

PureWeen · 2019-04-12T00:52:36Z

🤞

rookiejava · 2019-04-12T01:33:12Z

🎉

…rin#5453) * [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual * Update Tizen.NET.MaterialComponent for applying color scheme * Don't build XF.Material.Tzien on iPhone and iPhoneSimulator * Fix MCanvas build issue * Update build-windows.yml for XF.Material.Tizen

* [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual * Update Tizen.NET.MaterialComponent for applying color scheme * Don't build XF.Material.Tzien on iPhone and iPhoneSimulator * Fix MCanvas build issue * Update build-windows.yml for XF.Material.Tizen

…rin#5453) * [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual * Update Tizen.NET.MaterialComponent for applying color scheme * Don't build XF.Material.Tzien on iPhone and iPhoneSimulator * Fix MCanvas build issue * Update build-windows.yml for XF.Material.Tizen

rookiejava requested a review from StephaneDelcroix as a code owner March 5, 2019 11:34

samhouts added t/enhancement ➕ p/Tizen a/visual labels Mar 5, 2019

samhouts added this to In Review in v4.1.0 Mar 6, 2019

samhouts added retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. and removed retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. labels Mar 6, 2019

samhouts assigned StephaneDelcroix Mar 13, 2019

StephaneDelcroix approved these changes Mar 14, 2019

View reviewed changes

samhouts requested a review from PureWeen March 15, 2019 22:15

samhouts assigned PureWeen Mar 15, 2019

PureWeen approved these changes Apr 9, 2019

View reviewed changes

PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Apr 9, 2019

samhouts moved this from In Review to In Progress in v4.1.0 Apr 9, 2019

rookiejava force-pushed the add-xf-material-tizen branch from b0a55c2 to b769ff1 Compare April 11, 2019 00:54

rookiejava added 4 commits April 11, 2019 09:56

[Tizen] Adds Xamarin.Forms.Material.Tizen for Visual

1caa3b5

Update Tizen.NET.MaterialComponent for applying color scheme

c8aa469

Don't build XF.Material.Tzien on iPhone and iPhoneSimulator

b769ff1

Fix MCanvas build issue

797d874

Update build-windows.yml for XF.Material.Tizen

f62c9d6

PureWeen removed the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Apr 15, 2019

PureWeen merged commit fda800c into xamarin:master Apr 15, 2019

v4.1.0 automation moved this from In Progress to Done Apr 15, 2019

rookiejava deleted the add-xf-material-tizen branch April 16, 2019 01:27

samhouts added this to the 4.0.0 milestone Apr 29, 2019

samhouts removed this from Done in v4.1.0 Apr 30, 2019

samhouts added this to Done in v4.0.0 Apr 30, 2019

samhouts added p/Android approved Has two approvals, no pending reviews, and no changes requested labels Jul 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual #5453

[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual #5453

rookiejava commented Mar 5, 2019 •

edited by samhouts

StephaneDelcroix Mar 14, 2019

rookiejava Mar 15, 2019

rookiejava commented Apr 9, 2019

PureWeen left a comment

PureWeen commented Apr 9, 2019

rookiejava commented Apr 10, 2019

PureWeen commented Apr 10, 2019

rookiejava commented Apr 11, 2019 •

edited

PureWeen commented Apr 11, 2019

rookiejava commented Apr 11, 2019

PureWeen commented Apr 11, 2019

rookiejava commented Apr 12, 2019

PureWeen commented Apr 12, 2019

PureWeen commented Apr 12, 2019

rookiejava commented Apr 12, 2019

[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual #5453

[Material] [Tizen] Adds Xamarin.Forms.Material.Tizen for Visual #5453

Conversation

rookiejava commented Mar 5, 2019 • edited by samhouts

Description of Change

Issues Resolved

API Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

Testing Procedure

PR Checklist

StephaneDelcroix Mar 14, 2019

Choose a reason for hiding this comment

rookiejava Mar 15, 2019

Choose a reason for hiding this comment

rookiejava commented Apr 9, 2019

PureWeen left a comment

Choose a reason for hiding this comment

PureWeen commented Apr 9, 2019

rookiejava commented Apr 10, 2019

PureWeen commented Apr 10, 2019

rookiejava commented Apr 11, 2019 • edited

PureWeen commented Apr 11, 2019

rookiejava commented Apr 11, 2019

PureWeen commented Apr 11, 2019

rookiejava commented Apr 12, 2019

PureWeen commented Apr 12, 2019

PureWeen commented Apr 12, 2019

rookiejava commented Apr 12, 2019

rookiejava commented Mar 5, 2019 •

edited by samhouts

rookiejava commented Apr 11, 2019 •

edited