Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS/Android] Move Map camera to correct region on layout change #548

Merged
merged 2 commits into from Jan 3, 2017
Merged

[iOS/Android] Move Map camera to correct region on layout change #548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3816e08
Move to region on layout change
adrianknight89 Nov 18, 2016
204840f
remove visibility check
adrianknight89 Nov 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions Xamarin.Forms.Maps.Android/MapRenderer.cs
View file
Open in desktop
Expand Up @@ -186,6 +186,7 @@ protected override void OnLayout(bool changed, int l, int t, int r, int b)
else if (changed)
{
UpdateVisibleRegion(NativeMap.CameraPosition.Target);
MoveToRegion(Element.LastMoveToRegion, false);
}
}

Expand Down
2 changes: 1 addition & 1 deletion Xamarin.Forms.Maps.iOS/MapRenderer.cs
View file
Open in desktop
Expand Up @@ -190,7 +190,7 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE
UpdateHasScrollEnabled();
else if (e.PropertyName == Map.HasZoomEnabledProperty.PropertyName)
UpdateHasZoomEnabled();
else if (e.PropertyName == VisualElement.IsVisibleProperty.PropertyName && ((Map)Element).LastMoveToRegion != null)
else if (e.PropertyName == VisualElement.HeightProperty.PropertyName && ((Map)Element).LastMoveToRegion != null)
_shouldUpdateRegion = true;
}

Expand Down