New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old Alert/ActionSheet method for iOS 8 #595

Merged
merged 2 commits into from Dec 2, 2016

Conversation

Projects
None yet
4 participants
@hartez
Member

hartez commented Dec 2, 2016

Description of Change

The method of handling Action Sheets and Alerts introduced by PR 481 doesn't work properly on iOS 8; this change restores the old functionality for iOS 8 while preserving the new functionality for iOS 9 and up.

Bugs Fixed

  • Action Sheet and Alerts completely non-functional in iOS 8

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

hartez added some commits Nov 30, 2016

@dnfclas dnfclas added the cla-required label Dec 2, 2016

@rmarinho rmarinho merged commit 281090c into master Dec 2, 2016

1 check passed

Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3615, ignored: 10
Details

@rmarinho rmarinho deleted the alerts-actionsheets-ios8 branch Dec 2, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment