This repository has been archived by the owner on May 1, 2024. It is now read-only.
fix global routes to push onto stack correctly #6025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
paymicro
and removed request for
StephaneDelcroix
samhouts
approved these changes
Apr 29, 2019
samhouts
added
the
API-change
AxelUser
pushed a commit
to AxelUser/Xamarin.Forms
that referenced
this pull request
Jun 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Pages on shell sections were always just being pushed off. This change correctly interprets the URI request and then pushes or replaces accordingly
Issues Resolved
API Changes
Removed:
Platforms Affected
Testing Procedure
There is a unit test but you can try doing this
gotoasync("page")
gotoasync("page")
and make sure it creates a stack of two pages
PR Checklist