This repository has been archived by the owner on May 1, 2024. It is now read-only.
Make CollectionView SelectedItem and SelectedItems binding function correctly #6085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartez
force-pushed
the
cv-selection-binding
branch
from
ba478a7
to
d6f3e33
Compare
hartez
force-pushed
the
cv-selection-binding
branch
from
d6f3e33
to
9a19a3d
Compare
paymicro
reviewed
May 8, 2019
...n.Forms.Controls/GalleryPages/CollectionViewGalleries/SelectionGalleries/SelectionHelpers.cs
Outdated
Show resolved
Hide resolved
StephaneDelcroix
approved these changes
May 8, 2019
The accursed Linker strikes again! |
hartez
force-pushed
the
cv-selection-binding
branch
from
fd3ff29
to
52f2a9f
Compare
Closed
paymicro
approved these changes
May 21, 2019
|
Remaining test failures are unrelated to this PR. |
samhouts
approved these changes
May 28, 2019
samhouts
added
proposal-open
t/enhancement ➕
blocker
samhouts
added
the
approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
These changes make the
SelectedItemproperty two-way bindable so that binding to theSelectedItemproperty works as expected.These changes also update the
SelectedItemsproperty to be bindable from a viewmodel in an intuitive way.Also adds automated tests for single and multiple selection binding.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
PR Checklist