Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Apply round corners shape based on radius #6099

Merged
merged 7 commits into from May 7, 2019
Merged

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented May 5, 2019

Description of Change

Apply shape treatment with corner radius settings

Issues Resolved

Before/After Screenshots

image

Testing Procedure

Check visual gallery. I modified two of the frames to demonstrate different corner radiuses

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@PureWeen PureWeen added this to To do in v4.0.0 via automation May 5, 2019
@PureWeen PureWeen added this to the 4.0.0 milestone May 5, 2019
@PureWeen PureWeen added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/iOS 🍎 labels May 5, 2019
@PureWeen PureWeen changed the title Apply round corners shape based on radius [iOS] Apply round corners shape based on radius May 5, 2019
Xamarin.Forms.Material.iOS/MaterialFrameRenderer.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Material.iOS/MaterialFrameRenderer.cs Outdated Show resolved Hide resolved
Xamarin.Forms.Material.iOS/MaterialFrameRenderer.cs Outdated Show resolved Hide resolved
@samhouts samhouts moved this from To do to In Review in v4.0.0 May 6, 2019
- reapply theme on ios so corner is changeable
- force set ios border width to size
@PureWeen PureWeen requested a review from paymicro May 6, 2019 18:36
@PureWeen PureWeen changed the title [iOS] Apply round corners shape based on radius Apply round corners shape based on radius May 6, 2019
@PureWeen PureWeen merged commit bfd4ed0 into 4.0.0 May 7, 2019
v4.0.0 automation moved this from In Review to Done May 7, 2019
@samhouts samhouts deleted the fix_material_frame branch May 7, 2019 17:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/visual blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android p/iOS 🍎 t/bug 🐛
Projects
No open projects
v4.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants