This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Shell][Tizen] Add the MaterialShellRenderer on Tizen #6196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipelines run |
|
No pipelines are associated with this pull request. |
|
/AzurePipelines run |
|
No pipelines are associated with this pull request. |
rookiejava
reviewed
May 16, 2019
| @@ -9,7 +9,7 @@ | |||
| <PackageReference Include="Tizen.NET" Version="4.0.0"> | |||
| <ExcludeAssets>Runtime</ExcludeAssets> | |||
| </PackageReference> | |||
| <PackageReference Include="Tizen.NET.MaterialComponents" Version="0.9.5-preview" /> | |||
| <PackageReference Include="Tizen.NET.MaterialComponents" Version="0.9.6-preview" /> | |||
There was a problem hiding this comment.
Use 0.9.7-preview which is the latest version.
|
it would be better #6204 precede this PR. |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
@yourina do you mind rebase? thanks |
|
rebase please. |
samhouts
suggested changes
Jul 9, 2019
There was a problem hiding this comment.
Build failed:
Xamarin.Forms.Platform.Tizen\Shell\NavigationView.cs(102,11): Error CS0618: 'MenuItem.Icon' is obsolete: 'Icon is obsolete as of 4.0.0. Please use IconImageSource instead.'
--
| Xamarin.Forms.Platform.Tizen\Shell\NavigationView.cs(104,15): Error CS0618: 'MenuItem.Icon' is obsolete: 'Icon is obsolete as of 4.0.0. Please use IconImageSource instead.'
Fixed it. Thank you. |
|
Build still failing https://dev.azure.com/xamarin/public/_build/results?buildId=5692&view=results |
shyunMin
force-pushed
the
ShellMaterial
branch
from
067adde
to
f80a57e
Compare
|
Rebased. |
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* [Shell][Tizen] Add the MaterialShellRenderer on Tizen * Fixed the build fail * Update namespace
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* [Shell][Tizen] Add the MaterialShellRenderer on Tizen * Fixed the build fail * Update namespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR is for adding
MaterialShellRendereron Tizen.Issues Resolved
None
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Use
StoreShellPR Checklist