This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Remove call to update Image on button during measure #6274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
changed the title
PureWeen
commented
May 23, 2019
| @@ -241,12 +241,6 @@ protected override void OnLayout(bool changed, int l, int t, int r, int b) | |||
| base.OnLayout(changed, l, t, r, b); | |||
| } | |||
|
|
|||
| protected override void OnMeasure(int widthMeasureSpec, int heightMeasureSpec) | |||
| { | |||
| _buttonLayoutManager?.Update(); | |||
There was a problem hiding this comment.
@mattleibow if you can recall the reason for adding this code let me know please. I tested a few different scenarios with loading images through urls and loading them after the layout was set to see if removing this broke anything but I couldn't find a scenario where deleting this caused a problem
PureWeen
added
blocker
samhouts
approved these changes
May 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The invalidate measure call when used with fastrenderers was causing a ping pong effect when loading images
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist