#3659 #3660 WPF/GTK ListView ContextMenu, SelectionBehavior fix #6417

VladislavAntonyuk · 2019-06-05T13:06:25Z

Description of Change

Issues Resolved

API Changes

None

Platforms Affected

WPF
GTK

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

Rebased on top of the target branch at time of PR
Changes adhere to coding standard

dnfclas · 2019-06-05T13:06:40Z

All CLA requirements met.

rmarinho · 2019-06-05T15:38:03Z

/azp run

azure-pipelines · 2019-06-05T15:38:25Z

Azure Pipelines successfully started running 1 pipeline(s).

rmarinho · 2019-06-05T16:40:13Z

Build is failing you can check here https://dev.azure.com/xamarin/public/_build/results?buildId=2728&view=results

VladislavAntonyuk · 2019-06-05T17:57:39Z

Also fix for GTK:
System.NullReferenceException: Object reference not set to an instance of an object.
at Xamarin.Forms.Platform.GTK.Renderers.NavigationPageRenderer.UpdateBackgroundImage()
at Xamarin.Forms.Platform.GTK.Renderers.NavigationPageRenderer.OnElementChanged(VisualElementChangedEventArgs e)
at Xamarin.Forms.Platform.GTK.Renderers.AbstractPageRenderer`2.SetElement(VisualElement element)
at Xamarin.Forms.Platform.GTK.Platform.CreateRenderer(VisualElement element)
at Xamarin.Forms.Platform.GTK.Platform.AddChild(Page mainPage)
at Xamarin.Forms.Platform.GTK.Platform.SetPage(Page newRoot)
at Xamarin.Forms.Platform.GTK.FormsWindow.UpdateMainPage()
at Xamarin.Forms.Platform.GTK.FormsWindow.ApplicationOnPropertyChanged(Object sender, PropertyChangedEventArgs args)
at Xamarin.Forms.BindableObject.OnPropertyChanged(String propertyName)
at Xamarin.Forms.Element.OnPropertyChanged(String propertyName)
at Xamarin.Forms.Application.set_MainPage(Page value)
at

azure-pipelines · 2019-06-05T17:57:45Z

Commenter does not have sufficient privileges for PR 6417 in repo xamarin/Xamarin.Forms

samhouts · 2019-06-06T00:15:06Z

/azp run

azure-pipelines · 2019-06-06T00:15:24Z

Azure Pipelines successfully started running 1 pipeline(s).

Xamarin.Forms.Core/ListView.cs

mohachouch

Thanks for the PR.

VladislavAntonyuk · 2020-02-28T09:51:52Z

@rmarinho rebased on master

VladislavAntonyuk · 2020-06-24T18:48:55Z

@rmarinho please review

VladislavAntonyuk · 2020-08-10T15:28:00Z

@samhouts what is the target branch I should use?

samhouts · 2020-08-10T22:45:36Z

@VladislavAntonyuk 5.0.0, please! Thank you!

VladislavAntonyuk · 2020-08-10T23:10:19Z

@samhouts done

…vior fix (xamarin#6417) * Fix WPF and GTK * 3660 WPF ListView Cell Selection Behaviour * TableView fix mouse button * Fix Tapped is not invoked * Method to expression body * Fix build * CR fixes * Issue6417 * Rebase on master, new IListViewWithContextMenuController interface * Revert changes fixes xamarin#3659 fixes xamarin#3660

VladislavAntonyuk changed the title ~~Fix WPF and GTK~~ #3659 WPF/GTK ListView Cell ContextMenu - Fix WPF and GTK Jun 5, 2019

VladislavAntonyuk changed the title ~~#3659 WPF/GTK ListView Cell ContextMenu - Fix WPF and GTK~~ #3659 #3660 WPF/GTK ListView Jun 5, 2019

VladislavAntonyuk mentioned this pull request Jun 5, 2019

WPF ListView ItemTapped event when selected #3662

Closed

VladislavAntonyuk requested a review from StephaneDelcroix as a code owner June 5, 2019 14:03

samhouts added this to In Review in v4.2.0 Jun 5, 2019

samhouts added p/gtk p/WPF labels Jun 5, 2019

VladislavAntonyuk changed the title ~~#3659 #3660 WPF/GTK ListView~~ #3659 #3660 + NRE WPF/GTK ListView Jun 5, 2019

samhouts requested review from mohachouch and jsuarezruiz June 6, 2019 00:14

samhouts previously requested changes Jun 6, 2019

View reviewed changes

Xamarin.Forms.Core/ListView.cs Outdated Show resolved Hide resolved

Xamarin.Forms.Core/ListView.cs Outdated Show resolved Hide resolved

samhouts moved this from In Review to In Progress in v4.2.0 Jun 6, 2019

mohachouch approved these changes Jun 12, 2019

View reviewed changes

samhouts assigned samhouts and jsuarezruiz Jun 27, 2019

samhouts self-requested a review June 28, 2019 00:26

samhouts added the inactive Issue is older than 6 months and needs to be retested label Jul 4, 2019

samhouts changed the base branch from master to 4.2.0 July 4, 2019 04:06

samhouts requested review from PureWeen and removed request for samhouts July 9, 2019 02:05

samhouts assigned PureWeen and unassigned samhouts Jul 9, 2019

VladislavAntonyuk added 5 commits February 28, 2020 11:46

Fix build

95ee7bb

CR fixes

d4b81be

Issue6417

6fa2d9d

Rebase on master, new IListViewWithContextMenuController interface

246763a

Revert changes

106b934

samhouts removed this from In Progress in v4.6.0 Mar 2, 2020

samhouts approved these changes Mar 17, 2020

View reviewed changes

VladislavAntonyuk requested a review from samhouts June 16, 2020 11:01

samhouts changed the base branch from master to 4.8.0 June 26, 2020 00:16

samhouts changed the base branch from 4.8.0 to main July 30, 2020 00:10

samhouts added this to In Progress in .NET MAUI Backlog Jul 30, 2020

samhouts removed this from In Progress in vCurrent (4.8.0) Jul 30, 2020

samhouts added t/bug 🐛 retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. labels Aug 4, 2020

samhouts added this to the 5.0.0 milestone Aug 4, 2020

samhouts removed this from In Progress in .NET MAUI Backlog Aug 4, 2020

VladislavAntonyuk changed the base branch from main to 5.0.0 August 10, 2020 23:09

samhouts added this to In Progress in vNext+1 (5.0.0) Aug 11, 2020

samhouts merged commit 6d60f87 into xamarin:5.0.0 Aug 17, 2020

vNext+1 (5.0.0) automation moved this from In Progress to Done Aug 17, 2020

samhouts removed the retarget-branch-required PR or associated issues target a milestone. Please target this PR to the matching branch. label Aug 17, 2020

samhouts added this to Done in Sprint 175 Aug 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#3659 #3660 WPF/GTK ListView ContextMenu, SelectionBehavior fix #6417

#3659 #3660 WPF/GTK ListView ContextMenu, SelectionBehavior fix #6417

VladislavAntonyuk commented Jun 5, 2019 •

edited by samhouts

Loading

dnfclas commented Jun 5, 2019 •

edited

Loading

rmarinho commented Jun 5, 2019

azure-pipelines bot commented Jun 5, 2019

rmarinho commented Jun 5, 2019

VladislavAntonyuk commented Jun 5, 2019 •

edited

Loading

azure-pipelines bot commented Jun 5, 2019

samhouts commented Jun 6, 2019

azure-pipelines bot commented Jun 6, 2019

mohachouch left a comment

VladislavAntonyuk commented Feb 28, 2020

VladislavAntonyuk commented Jun 24, 2020

VladislavAntonyuk commented Aug 10, 2020

samhouts commented Aug 10, 2020

VladislavAntonyuk commented Aug 10, 2020

#3659 #3660 WPF/GTK ListView ContextMenu, SelectionBehavior fix #6417

#3659 #3660 WPF/GTK ListView ContextMenu, SelectionBehavior fix #6417

Conversation

VladislavAntonyuk commented Jun 5, 2019 • edited by samhouts Loading

Description of Change

Issues Resolved

API Changes

Platforms Affected

Behavioral/Visual Changes

Before/After Screenshots

Testing Procedure

PR Checklist

dnfclas commented Jun 5, 2019 • edited Loading

rmarinho commented Jun 5, 2019

azure-pipelines bot commented Jun 5, 2019

rmarinho commented Jun 5, 2019

VladislavAntonyuk commented Jun 5, 2019 • edited Loading

azure-pipelines bot commented Jun 5, 2019

samhouts commented Jun 6, 2019

azure-pipelines bot commented Jun 6, 2019

mohachouch left a comment

Choose a reason for hiding this comment

VladislavAntonyuk commented Feb 28, 2020

VladislavAntonyuk commented Jun 24, 2020

VladislavAntonyuk commented Aug 10, 2020

samhouts commented Aug 10, 2020

VladislavAntonyuk commented Aug 10, 2020

VladislavAntonyuk commented Jun 5, 2019 •

edited by samhouts

Loading

dnfclas commented Jun 5, 2019 •

edited

Loading

VladislavAntonyuk commented Jun 5, 2019 •

edited

Loading