This repository has been archived by the owner on May 1, 2024. It is now read-only.
[C] Obsolete Device.OpenUri #6844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix identation to use tabs
Xamarin.Forms.Core/Device.cs
Outdated
| { | ||
| PlatformServices.OpenUriAction(uri); | ||
| } | ||
| [Obsolete("Use Launcher.OpenUri (or CanOpen, or TryOpen) from Xamarin.Essentials")] |
There was a problem hiding this comment.
if you're looking for it, here's the only meaningful change ^^^
StephaneDelcroix
force-pushed
the
obsoleteOpenUri
branch
from
9e81a5c
to
9a93a4c
Compare
samhouts
reviewed
Jul 17, 2019
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
jsuarezruiz
approved these changes
Jul 19, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* [C] Obsolete Device.OpenUri also fix identation to use tabs * fix CS618 * Update Xamarin.Forms.Core/Device.cs Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* [C] Obsolete Device.OpenUri also fix identation to use tabs * fix CS618 * Update Xamarin.Forms.Core/Device.cs Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
see #6623
also fix identation to use tabs
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist