This repository has been archived by the owner on May 1, 2024. It is now read-only.
[iOS] UITableView.Appearance.BackgroundColor ignored or overridden for ListView #6910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
t/bug 🐛
p/iOS 🍎
i/regression
i/low
samhouts
added
the
retarget-branch-required
samhouts
approved these changes
Jul 29, 2019
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5503.cs
Outdated
Show resolved
Hide resolved
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5503.cs
Outdated
Show resolved
Hide resolved
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue5503.cs
Outdated
Show resolved
Hide resolved
# Conflicts: # Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Xamarin.Forms.Controls.Issues.Shared.projitems
Co-Authored-By: Samantha Houts <samhouts@users.noreply.github.com>
jfversluis
removed
the
retarget-branch-required
|
@samhouts done! Builds and tests running now |
hartez
approved these changes
Jul 29, 2019
|
Failing tests are unrelated |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
As described in #5503 the color set in the Appearance API was not respected. Fixed this by adding a check for that in the code of #4002 that caused this behavior.
I added a UI test but could not get the color out of the
ListViewthey always returned the same value. Marked it as manual review.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist