Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[C] force update size on View updated #6936

Merged
merged 2 commits into from Aug 15, 2019
Merged

[C] force update size on View updated #6936

merged 2 commits into from Aug 15, 2019

Conversation

StephaneDelcroix
Copy link
Member

Description of Change

when a ViewCell View property is updated, the actual rendered cell is blank

Issues Resolved

fixes HotReload

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts added this to In Review in v4.1.0 Jul 19, 2019
@felipemomm
Copy link
Contributor

Just wondering, does it happen only on HotReload? If so, won't it make the performance worse on release mode? Perhaps it should call this method only on DEBUG?

@StephaneDelcroix
Copy link
Member Author

@felipemomm it can be reproduced by switching ViewCell.View, but no one ever done that before. the perf hit only applies when actually reassigning the View, and we just proved that no one does that, so it should be fine

@KSemenenko
Copy link
Contributor

KSemenenko commented Aug 14, 2019

There is a bug #6638 that can be related, it occurs in the ListView on iOS when the ReculceElement reuse the cell, changing the BindingContext. The BindingContext is changing, but the cell size is not.
And I think that after changing the BindingContext, perhaps need to call ForceUpdateSize too.
@StephaneDelcroix

@StephaneDelcroix StephaneDelcroix changed the base branch from 4.1.0 to 4.2.0 August 15, 2019 06:21
@samhouts samhouts removed this from In Review in v4.1.0 Aug 15, 2019
@samhouts samhouts added this to In Review in v4.2.0 Aug 15, 2019
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Aug 15, 2019
@samhouts samhouts merged commit 4fa312d into 4.2.0 Aug 15, 2019
v4.2.0 automation moved this from In Review to Done Aug 15, 2019
@samhouts samhouts deleted the hr_forceresize branch August 15, 2019 22:41
@samhouts samhouts added this to the 4.2.0 milestone Aug 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Has two approvals, no pending reviews, and no changes requested
Projects
No open projects
v4.2.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants