This repository has been archived by the owner on May 1, 2024. It is now read-only.
Adds a null check for Xamarin.Forms.Platform.Android.PageRenderer.Xamarin.Forms.Platform.Android.IOrderedTraversalController.UpdateTraversalOrder #7050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happypig375
changed the title
This was referenced Aug 2, 2019
jfversluis
suggested changes
Aug 6, 2019
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7049.cs
Outdated
Show resolved
Hide resolved
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7049.cs
Outdated
Show resolved
Hide resolved
jfversluis
reviewed
Aug 6, 2019
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue7049.cs
Outdated
Show resolved
Hide resolved
jfversluis
approved these changes
Aug 6, 2019
jsuarezruiz
approved these changes
Aug 6, 2019
|
How to view what failed? |
|
@Happypig375 I'm afraid you can't sorry! Doing another run and I will let you know if anything it wrong when it's done |
|
@jfversluis The run is done |
|
The failed tests are the same as #7012. Therefore, this PR is technically fine. |
|
I love that line of thought, but unfortunately that is not how it works 😉 each of these runs has hundreds of tests in it so it might just as well be that your changes broke some. It's impossible to say from just this data. I've just checked manually and the failing tests do seem unrelated. Thank you for your contribution! |
samhouts
pushed a commit
to rookiejava/Xamarin.Forms
that referenced
this pull request
Aug 16, 2019
…arin.Forms.Platform.Android.IOrderedTraversalController.UpdateTraversalOrder (xamarin#7050) * Fixes xamarin#7049 * Test? * Tap View please * Spacing * Address comments * Excuse me, semicolons * Remove private
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…arin.Forms.Platform.Android.IOrderedTraversalController.UpdateTraversalOrder (xamarin#7050) * Fixes xamarin#7049 * Test? * Tap View please * Spacing * Address comments * Excuse me, semicolons * Remove private
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
…arin.Forms.Platform.Android.IOrderedTraversalController.UpdateTraversalOrder (xamarin#7050) * Fixes xamarin#7049 * Test? * Tap View please * Spacing * Address comments * Excuse me, semicolons * Remove private
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds a null check for
ve.GetRenderer()inXamarin.Forms.Platform.Android.PageRenderer.Xamarin.Forms.Platform.Android.IOrderedTraversalController.UpdateTraversalOrder.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Apps that directly assign views to children of layouts will no longer crash due to a null reference.
Before/After Screenshots
Before:
After:
Testing Procedure
Automated test
PR Checklist