Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] make VisualElementExtensions public on iOS #7144

Merged
merged 1 commit into from Aug 14, 2019
Merged

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Aug 13, 2019

Description of Change

This extension is already public on UWP and Android

Issues Resolved

API Changes

Added:

  • IVisualElementRenderer VisualElementExtensions.GetRenderer

Platforms Affected

  • iOS

Testing Procedure

No testing needed

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@StephaneDelcroix StephaneDelcroix merged commit 20b9a4b into master Aug 14, 2019
v4.3.0 automation moved this from In Review to Done Aug 14, 2019
@StephaneDelcroix StephaneDelcroix deleted the fix_7142 branch August 14, 2019 15:01
@samhouts samhouts removed this from Done in v4.3.0 Sep 3, 2019
@samhouts samhouts added this to the 4.3.0 milestone Sep 11, 2019
@samhouts samhouts added this to Done in v4.3.0 Sep 11, 2019
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v4.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

VisualElementExtensions.cs iOS is Internal. Can it be Public?
5 participants