Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android/iOS] RefreshView #7214

Merged
merged 33 commits into from Aug 29, 2019
Merged

[Android/iOS] RefreshView #7214

merged 33 commits into from Aug 29, 2019

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Aug 20, 2019

Description of Change

RefreshView represents a container control that provides pull-to-refresh functionality for scrollable content.

fixes #5882

Screenshots

Android
refreshview-droid

iOS
refreshview-ios2

API Changes

public class RefreshView : ContentView
{
	public static readonly BindableProperty CommandProperty;
	public ICommand Command { get; set; }

	public static readonly BindableProperty CommandParameterProperty;
	public object CommandParameter { get; set; }

	public static readonly BindableProperty IsEnabledProperty;
	public bool IsEnabled { get; set; }

	public bool IsRefreshing { get; set; }

	public Color BackgroundColor {get; set;}
	public Color RefreshColor {get; set;}
}

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

In Core Gallery access to the RefreshView samples. Try to pull to refresh the content. A load indicator should appear and refresh the content.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@PureWeen PureWeen changed the title Swiperefresh [WiP] Swiperefresh Aug 20, 2019
@PureWeen PureWeen added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Aug 20, 2019
Small changes in RefreshView iOS renderer.
Updated Core Gallery RefreshView samples.
@jsuarezruiz jsuarezruiz changed the title [WiP] Swiperefresh [WiP] RefreshView Aug 21, 2019
Copy link
Contributor

@hartez hartez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor whitespace things and possibly an opportunity to simplify.

Xamarin.Forms.Platform.UAP/Resources.xaml Outdated Show resolved Hide resolved
@hartez
Copy link
Contributor

hartez commented Aug 28, 2019

Where's the UWP implementation?

@samhouts samhouts moved this from In Review to In Progress in v4.3.0 Aug 28, 2019
@PureWeen
Copy link
Contributor Author

PureWeen commented Aug 28, 2019

@hartez

Where's the UWP implementation?

That will show up in separate PR so we can workout some WinUI issues and not hold up iOS/Android

@samhouts samhouts requested a review from hartez August 29, 2019 00:27
@jsuarezruiz
Copy link
Contributor

UWP implementation was included. It also had a Platform Specific to set the pull to refresh orientation.
refreshdirection-uwp

In UWP we used the Microsoft.UI.Xaml NuGet. After several tests, we found problems to solve. To avoid delaying this functionality we have decided to split into two branches. For now, in this PR we will add the functionality in Android and iOS and as for UWP, we created another branch (https://github.com/xamarin/Xamarin.Forms/blob/swiperefresh-uwp/Xamarin.Forms.Platform.UAP/RefreshViewRenderer.cs) and are in conversation with the WinUI team to find the best solution in UWP.

@samhouts samhouts merged commit bcf1d85 into master Aug 29, 2019
v4.3.0 automation moved this from In Progress to Done Aug 29, 2019
CollectionView automation moved this from In Review to Done Aug 29, 2019
@samhouts samhouts deleted the swiperefresh branch August 29, 2019 21:09
@samhouts samhouts moved this from Done to In Progress in v4.3.0 Aug 29, 2019
@samhouts samhouts added this to In progress in Sprint 158 Aug 29, 2019
@samhouts samhouts moved this from In Progress to Done in v4.3.0 Aug 29, 2019
@samhouts samhouts moved this from In progress to Done in Sprint 158 Aug 29, 2019
@PureWeen PureWeen restored the swiperefresh branch August 30, 2019 00:06
@samhouts samhouts added this to Done in v4.4.0 Aug 30, 2019
@PureWeen PureWeen deleted the swiperefresh branch August 30, 2019 00:26
@samhouts samhouts removed this from Done in v4.3.0 Sep 3, 2019
@samhouts samhouts added this to the 4.3.0 milestone Sep 11, 2019
@samhouts samhouts removed this from Done in v4.4.0 Sep 11, 2019
@samhouts samhouts added this to Done in v4.3.0 Sep 11, 2019
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
* Swipe To Refresh

* pull in pull to refresh

* api changes

* Added RefreshView CoreGallery and Gallery Samples (using ScrollView, ListView, CollectionView, etc.)

* Code refactoring in RefreshViewRenderer (iOS)

* Updated RefreshView Android Renderer

* Fixed RefreshView Android samples in Core Gallery

* Added initial RefreshView UWP implementation

* Added another UWP RefreshView renderer using WinUI NuGet controls (RefreshContainer)

* - additional linker settings

* - uwp fixes

* - disable SkipMicrosoftUIXamlCheckTargetPlatformVersion check

* Update .nuspec/Xamarin.Forms.targets

* Limited RefreshView in Android to support only content using scroll.
Small changes in RefreshView iOS renderer.
Updated Core Gallery RefreshView samples.

* Fixed Visualizer colors in UWP RefreshView

* Added UWP RefreshPullDirection Platform Specific

* Small changes in code syntax in iOS renderer.

* Removed some unnecessary curly braces .

* Register effect provider in iOS RefreshView

* Changes in RefreshView UWP Dispose

* Added conditional code to manage the refresh control differently if it is iOS 10 or higher.

* Fixed error in Android Core Gallery (Linker)
Code refactoring and small changes (PR Feedback)

* Changes disposing the Android renderer

* - fix SkipMicrosoftUIXamlCheckTargetPlatformVersion so it can be turned off

* Removed UWP RefreshView renderer and Platform Specific

* - remove winui from nuspec

* - remove skip checks from targets

* - remove XamlControlsResources

* - remove skip check on UAP platform

* Revert changes in Android Core Gallery manifiest

* Revert unnecessary space in UAP Platform csproj

* Removed unnecessary new line in UWP Resources

* Simplified RefreshView iOS Renderer.
fixes xamarin#5882
felipebaltazar pushed a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Oct 16, 2019
* Swipe To Refresh

* pull in pull to refresh

* api changes

* Added RefreshView CoreGallery and Gallery Samples (using ScrollView, ListView, CollectionView, etc.)

* Code refactoring in RefreshViewRenderer (iOS)

* Updated RefreshView Android Renderer

* Fixed RefreshView Android samples in Core Gallery

* Added initial RefreshView UWP implementation

* Added another UWP RefreshView renderer using WinUI NuGet controls (RefreshContainer)

* - additional linker settings

* - uwp fixes

* - disable SkipMicrosoftUIXamlCheckTargetPlatformVersion check

* Update .nuspec/Xamarin.Forms.targets

* Limited RefreshView in Android to support only content using scroll.
Small changes in RefreshView iOS renderer.
Updated Core Gallery RefreshView samples.

* Fixed Visualizer colors in UWP RefreshView

* Added UWP RefreshPullDirection Platform Specific

* Small changes in code syntax in iOS renderer.

* Removed some unnecessary curly braces .

* Register effect provider in iOS RefreshView

* Changes in RefreshView UWP Dispose

* Added conditional code to manage the refresh control differently if it is iOS 10 or higher.

* Fixed error in Android Core Gallery (Linker)
Code refactoring and small changes (PR Feedback)

* Changes disposing the Android renderer

* - fix SkipMicrosoftUIXamlCheckTargetPlatformVersion so it can be turned off

* Removed UWP RefreshView renderer and Platform Specific

* - remove winui from nuspec

* - remove skip checks from targets

* - remove XamlControlsResources

* - remove skip check on UAP platform

* Revert changes in Android Core Gallery manifiest

* Revert unnecessary space in UAP Platform csproj

* Removed unnecessary new line in UWP Resources

* Simplified RefreshView iOS Renderer.
fixes xamarin#5882
@samhouts samhouts removed this from Done in CollectionView May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Sprint 158
  
Done
v4.3.0
  
Done
Development

Successfully merging this pull request may close these issues.

[Spec] RefreshView
8 participants