New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] connect the actual ObservableCollection to the ItemsSource #725

Merged
merged 6 commits into from Feb 23, 2017

Conversation

Projects
None yet
6 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Jan 27, 2017

Description of Change

[UWP] connect the actual ObservableCollection to the ComboBox.ItemsSource as it looks like ComboBox doesn't correctly connect to INPC or INPP on a non-ObservableCollection<> ItemsSource. We'd have to look at the ComboBox source to be 100% sure...

The workaround is then to expose our collection as internal

Bugs Fixed

API Changes

Behavioral Changes

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@pauldipietro

This comment has been minimized.

Show comment
Hide comment
@pauldipietro

pauldipietro Jan 31, 2017

Member

@StephaneDelcroix: On my end, it looks like that the changes break this on Android (both FormsActivity/AppCompat) and the items aren't showing up. iOS seems okay.

There's another issue I'm seeing too where if you add a label to the repro and have it set the text to whatever the SelectedItem is when SelectedIndexChanged fires, the first time something is selected, it's null. That appears to be occurring here because the event's getting invoked before the SelectedItem is updated; swapping their order appears to fix the issue (it also looks vaguely similar to 39407). If you want, I could make that change as another PR for history clarity, or you could include it in this one, since I'm assuming it's legitimate?

Member

pauldipietro commented Jan 31, 2017

@StephaneDelcroix: On my end, it looks like that the changes break this on Android (both FormsActivity/AppCompat) and the items aren't showing up. iOS seems okay.

There's another issue I'm seeing too where if you add a label to the repro and have it set the text to whatever the SelectedItem is when SelectedIndexChanged fires, the first time something is selected, it's null. That appears to be occurring here because the event's getting invoked before the SelectedItem is updated; swapping their order appears to fix the issue (it also looks vaguely similar to 39407). If you want, I could make that change as another PR for history clarity, or you could include it in this one, since I'm assuming it's legitimate?

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Feb 1, 2017

Member

@pauldipietro push to this branch, it's fine

Member

StephaneDelcroix commented Feb 1, 2017

@pauldipietro push to this branch, it's fine

@pauldipietro

This comment has been minimized.

Show comment
Hide comment
@pauldipietro

pauldipietro Feb 1, 2017

Member

I pushed that change which you can take a peek at, but Android still has issues with the items not showing up.

Member

pauldipietro commented Feb 1, 2017

I pushed that change which you can take a peek at, but Android still has issues with the items not showing up.

pauldipietro and others added some commits Feb 10, 2017

@TomQv

This comment has been minimized.

Show comment
Hide comment
@TomQv

TomQv Feb 21, 2017

When will this be merged?
Its desperatly awaited...

TomQv commented Feb 21, 2017

When will this be merged?
Its desperatly awaited...

@pauldipietro

I think this should be okay with [Preserve] having been added in for Android.

@pauldipietro pauldipietro merged commit 81d6812 into master Feb 23, 2017

6 checks passed

Android-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 353, i…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: Windows Debug : Tests passed: 3743, ignored: 10
Details
iOS10-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests passed: 35…
Details
iOS8-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified IOS8 : Tests passed: 351…
Details
iOS9-UITests-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 353…
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-bz51642 branch Mar 3, 2017

@samhouts samhouts added this to the 2.3.5 milestone Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment