This repository has been archived by the owner on May 1, 2024. It is now read-only.
Implement CarouselView on UWP #7503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
reviewed
Sep 13, 2019
Xamarin.Forms.Platform.UAP/CollectionView/CarouselViewRenderer.cs
Outdated
Show resolved
Hide resolved
Xamarin.Forms.Platform.UAP/CollectionView/CarouselViewRenderer.cs
Outdated
Show resolved
Hide resolved
Xamarin.Forms.Platform.UAP/CollectionView/CarouselViewRenderer.cs
Outdated
Show resolved
Hide resolved
jsuarezruiz
force-pushed
the
carouselview-uwp
branch
from
2e85f31
to
c6c9e75
Compare
rmarinho
approved these changes
Sep 16, 2019
jsuarezruiz
force-pushed
the
carouselview-uwp
branch
from
0655a39
to
500c9ec
Compare
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Implemented CarouselView on UWP * Implemented CurrentItem on Carousel UWP * Fixed ArgumentOutOfRangeException with the Carousel position * Removed code to update the CurrentItem on UWP (review it to improve)
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Oct 16, 2019
* Implemented CarouselView on UWP * Implemented CurrentItem on Carousel UWP * Fixed ArgumentOutOfRangeException with the Carousel position * Removed code to update the CurrentItem on UWP (review it to improve)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Makes the CarouselView functionality work on UWP.
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch UWP Core Gallery and try the CarouselView Core sample.
PR Checklist