[Android] Fix bug. Children pages in NavigationPage were got appearing events even if they were not latest in navigation stack
#758
Conversation
…e were not last in NavigationStack
|
Hi @rotorgames, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
|
@rotorgames, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@hartez @jassmith @StephaneDelcroix Any news about it? I can not use the single instance of I want to see it in v2.3.4 so much. Please review it. |
|
@rmarinho Hello. Will we be able to see it in new release soon? |
| @@ -589,6 +585,46 @@ void SetupToolbar() | |||
| _toolbar = bar; | |||
| } | |||
|
|
|||
| void InsertPages(IEnumerable<Page> pages) | |||
There was a problem hiding this comment.
Not a fan to add another way to insert pages to the fragment stack. Can't we fix the problem just on SwitchContentAsync ?
There was a problem hiding this comment.
Ok. I will try to do it soon
|
@hartez can you take a look at this please. Thanks |
|
no activity. closing. reopen (or open a new one) when the comments are addressed |
Context: https://github.com/dotnet/core/blob/79c19c12ab2bc11912551bb0c3025f602cd541d9/Documentation/diagnostics/portable_pdb.md In doing some performance testing with builds in VS 2019, I noticed: 115 ms _ConvertPdbFiles 1 calls And looking at files were converted: ConvertDebuggingFiles Parameters Files C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.pdb [Output] ConvertedFiles: C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.dll The Xamarin.Essentials NuGet package is shipping a non-portable PDB file. This is a Windows-specific format that Mono doesn't support. Xamarin.Android runs a tool called `pdb2mdb` when it encounters a non-portable PDB file so symbols be converted to something that Mono can use. If you have `DebugType=full` or `DebugType=pdbonly`, Xamarin.Android has to do this extra work to convert it. I see no drawbacks to just use `DebugType=portable` in this project all the time? Since Xamarin.Essentials uses sourcelink, I double-checked and they support portable PDBs: https://github.com/dotnet/sourcelink#prerequisites-for-net-projects I sent a similar PR to Xamarin.Forms, shipping since 3.4. I wrote a bit more detail on symbol files there if you need more info: #4201
Context: https://github.com/dotnet/core/blob/79c19c12ab2bc11912551bb0c3025f602cd541d9/Documentation/diagnostics/portable_pdb.md In doing some performance testing with builds in VS 2019, I noticed: 115 ms _ConvertPdbFiles 1 calls And looking at files were converted: ConvertDebuggingFiles Parameters Files C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.pdb [Output] ConvertedFiles: C:\ProgramData\Xamarin\NuGet\xamarin.essentials\1.0.1\lib\monoandroid81\Xamarin.Essentials.dll The Xamarin.Essentials NuGet package is shipping a non-portable PDB file. This is a Windows-specific format that Mono doesn't support. Xamarin.Android runs a tool called `pdb2mdb` when it encounters a non-portable PDB file so symbols be converted to something that Mono can use. If you have `DebugType=full` or `DebugType=pdbonly`, Xamarin.Android has to do this extra work to convert it. I see no drawbacks to just use `DebugType=portable` in this project all the time? Since Xamarin.Essentials uses sourcelink, I double-checked and they support portable PDBs: https://github.com/dotnet/sourcelink#prerequisites-for-net-projects I sent a similar PR to Xamarin.Forms, shipping since 3.4. I wrote a bit more detail on symbol files there if you need more info: #4201
Description of Change
If add the
NavigationPagein an UI stack and push two pages, later delete theNavigationPagefrom the UI stack and add it again, all pages in theNavigationStackwill haveOnAppearingevent, even if they will not be latest inNavigationStack. Also if do toPopAsync, hidden pages will not getOnAppearingevent.Bugs Fixed
API Changes
None
Behavioral Changes
None
PR Checklist