This repository has been archived by the owner on May 1, 2024. It is now read-only.
[C] support more color format in ColorTypeConverter #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
approved these changes
Feb 23, 2017
| case "WhiteSmoke": return Color.WhiteSmoke; | ||
| case "Yellow": return Color.Yellow; | ||
| case "YellowGreen": return Color.YellowGreen; | ||
| switch (color.ToLowerInvariant()) { |
There was a problem hiding this comment.
@samhouts I bet it was fun to review, trying to find the one place an uppercase was left, or the one time I mixed gray with blue, accidentally creating the glue color.
| Assert.AreEqual(Color.Blue.MultiplyAlpha(.8), converter.ConvertFromInvariantString("hsla(240,100%, 50%, .8)")); | ||
| Assert.AreEqual(Color.Default, converter.ConvertFromInvariantString("Color.Default")); | ||
| Assert.AreEqual(Color.Accent, converter.ConvertFromInvariantString("Accent")); | ||
| var hotpink = Color.FromHex("#FF69B4"); | ||
| Color.Accent = hotpink; | ||
| Assert.AreEqual (Color.Accent, converter.ConvertFromInvariantString ("Accent")); | ||
| Assert.Throws<InvalidOperationException> (() => converter.ConvertFromInvariantString ("")); |
There was a problem hiding this comment.
Maybe also add some Assert.Throws for parentheses violations (e.g., ColorTypeConverter, L28).
There was a problem hiding this comment.
I'm still unsure about how this should behave on error. While parsing Xaml, we throw, but while parsing css any-other-markup, we might want to revert to default.
adding a test nonetheless
samhouts
reviewed
Feb 23, 2017
| Assert.AreEqual(Color.Blue, converter.ConvertFromInvariantString("rgb(0,0, 255)")); | ||
| Assert.AreEqual(Color.Blue, converter.ConvertFromInvariantString("rgb(0,0, 300)")); | ||
| Assert.AreEqual(Color.Blue, converter.ConvertFromInvariantString("rgb(0,0, 300)")); | ||
| Assert.AreEqual(Color.Blue.MultiplyAlpha(.8), converter.ConvertFromInvariantString("rgba(0%,0%, 100%, .8)")); |
There was a problem hiding this comment.
WORKSFORME... investigating...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[C] support more color format in ColorTypeConverter
Bugs Fixed
/
API Changes
/
Behavioral Changes
/
PR Checklist