Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fixe issue 5367 | Crash assigning excessively long text to Editor with MaxLength property set #8052

Merged
merged 5 commits into from Nov 4, 2019
Merged

Fixe issue 5367 | Crash assigning excessively long text to Editor with MaxLength property set #8052

merged 5 commits into from Nov 4, 2019

Conversation

felipebaltazar
Copy link
Contributor

Description of Change

I've created ProcessTextWithMaxLenght method to process MaxLength property if needed

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

When you have an Editor control with a MaxLength set, and you assign it text longer than the MaxLength, it doesn't crash anymore

Before/After Screenshots

Not applicable

Testing Procedure

  1. Have an Editor in a page, with MaxLength=500
  2. Assign it a 1000 character string after initialization
  • Or simply run the 5367 test from ControlGallery

image

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added p/Android hacktoberfest 🍻 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often t/bug 🐛 labels Oct 17, 2019
@samhouts samhouts added this to In Review in v4.3.0 Oct 17, 2019
@samhouts samhouts moved this from In Review to In Progress in v4.3.0 Oct 17, 2019
v4.3.0 automation moved this from In Progress to In Review Oct 18, 2019
rmarinho
rmarinho suggested changes Oct 18, 2019
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, almost there, I tried the fix but i get a crash playing with it, check my comment on SetSelection length.

Xamarin.Forms.Platform.Android/Renderers/EditorRenderer.cs Show resolved Hide resolved
@samhouts samhouts moved this from In Review to In Progress in v4.3.0 Oct 18, 2019
@samhouts samhouts changed the base branch from 4.3.0 to master October 18, 2019 17:34
@samhouts samhouts added this to In Progress in v4.4.0 Oct 18, 2019
@samhouts samhouts removed this from In Progress in v4.3.0 Oct 18, 2019
rmarinho
rmarinho approved these changes Oct 23, 2019
View reviewed changes
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing test not related

@felipebaltazar
Copy link
Contributor Author

Any position about this PR?
Seems like all is fine to merge 😜

@samhouts samhouts added this to In Progress in v4.5.0 Nov 2, 2019
@samhouts samhouts removed this from In Progress in v4.4.0 Nov 2, 2019
@samhouts samhouts assigned jsuarezruiz and unassigned hartez Nov 4, 2019
@samhouts samhouts removed the request for review from rmarinho November 4, 2019 18:12
@rmarinho rmarinho merged commit fb672c1 into xamarin:master Nov 4, 2019
v4.5.0 automation moved this from In Progress to Done Nov 4, 2019
@felipebaltazar felipebaltazar deleted the issues/5367 branch November 4, 2019 22:37
felipebaltazar added a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Dec 1, 2019
@felipebaltazar
Fixe issue 5367 | Crash assigning excessively long text to Editor wit…
df89a42 
…h MaxLength property set (xamarin#8052) fixes xamarin#5367

* Fixe issue 5367 🐛

* Code review

* code review
felipebaltazar added a commit to felipebaltazar/Xamarin.Forms that referenced this pull request Dec 1, 2019
@felipebaltazar
Fixe issue 5367 | Crash assigning excessively long text to Editor wit…
8eb8cd5 
…h MaxLength property set (xamarin#8052) fixes xamarin#5367

* Fixe issue 5367 🐛

* Code review

* code review
@felipebaltazar felipebaltazar mentioned this pull request Dec 1, 2019
Merged
2 tasks
@samhouts samhouts added this to the 4.5.0 milestone Jan 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@campersau campersau campersau left review comments

@StephaneDelcroix StephaneDelcroix StephaneDelcroix requested changes

@rmarinho rmarinho rmarinho approved these changes

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

Assignees

@rmarinho rmarinho

@jsuarezruiz jsuarezruiz

Labels
hacktoberfest 🍻 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/Android t/bug 🐛
Projects
No open projects
v4.5.0
  
Done
Milestone
4.5.0
Development

Successfully merging this pull request may close these issues.

Crash assigning excessively long text to Editor with MaxLength property set
7 participants
@felipebaltazar @StephaneDelcroix @rmarinho @campersau @jsuarezruiz @hartez @samhouts