This repository has been archived by the owner on May 1, 2024. It is now read-only.
[macOS] Visual glitch when exiting the full screen with ScrollViewer #8086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
approved these changes
Oct 22, 2019
jsuarezruiz
approved these changes
Oct 29, 2019
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Dec 1, 2019
…amarin#8086) fixes xamarin#4854 * added test for issue4854 * fix issue4854
felipebaltazar
pushed a commit
to felipebaltazar/Xamarin.Forms
that referenced
this pull request
Dec 1, 2019
…amarin#8086) fixes xamarin#4854 * added test for issue4854 * fix issue4854
Merged
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Calculation of Y offset in ScrollViewer is improved. Now visual glitch when exiting the full screen with ScrollViewer is gone.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
The app returns to the previous state when exiting the full screen.
Before/After Screenshots
Not applicable
Testing Procedure
Manual tests included in Xamarin.Forms.Controls.Issues: Issue4854
PR Checklist